NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/60760: lpt(4) concurrency issues



> Date: Thu, 24 Sep 2026 15:18:21 +0200
> From: Johann Höpfner <hoepf%cit.tum.de@localhost>
> 
> > +out:	if (locked) {
> > +		sc->sc_state &= LPT_WRITING;
> > +		wakeup(&sc->sc_state);
> > +	}
> > +	splx(s);
> 
> I believe you want to clear LPT_WRITING here. You are clearing all other
> bits though.

You would believe correctly.  Oops.

> >  	return 0;
> 
> Maybe return error here instead of 0.

Yes, that sounds like a good idea!

Thanks for the review!



Home | Main Index | Thread Index | Old Index