NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

lib/60483: [libkvm] Remove unused macro



>Number:         60483
>Category:       lib
>Synopsis:       [libkvm] Remove unused macro
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 23 15:40:00 +0000 2026
>Originator:     ALEXANDR KULESHOV
>Release:        11.0_RC7
>Organization:
>Environment:
NetBSD netbsd 11.0_RC7 NetBSD 11.0_RC7 (GENERIC) #0: Wed Jul 22 05:26:24 UTC 2026  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/amd64/compile/GENERIC amd64

>Description:
lib/libkvm/kvm_sun3x.c defines two file-local macros - _kvm_kvas_size() and _kvm_nkptes() which are not referenced anywhere in the file.

They seems appear to be leftovers from an earlier version of the address translation code.

A little patch attached to remove dead macros.
>How-To-Repeat:
Code inspection of lib/libkvm/kvm_sun3x.c
>Fix:
Index: ./libkvm/kvm_sun3x.c
===================================================================
RCS file: /cvsroot/src/lib/libkvm/kvm_sun3x.c,v
retrieving revision 1.12
diff -u -r1.12 kvm_sun3x.c
--- ./libkvm/kvm_sun3x.c	14 Sep 2011 12:37:55 -0000	1.12
+++ ./libkvm/kvm_sun3x.c	23 Jul 2026 15:33:06 -0000
@@ -70,10 +70,6 @@
 	_kvm_sun3x_kvatop,
 	_kvm_sun3x_pa2off };
 
-#define	_kvm_kvas_size(h)	\
-	(-((h)->kernbase))
-#define	_kvm_nkptes(h, v)	\
-	(_kvm_kvas_size((h)) >> (v)->pgshift)
 #define	_kvm_pg_pa(pte, h)	\
 	((pte) & (h)->pg_frame)
 




Home | Main Index | Thread Index | Old Index