Re: lib/58282: Sysinst terminal output size increased because curses

[Brett Lymn <blymn%internode.on.net@localhost>]

On Thu, Feb 13, 2025 at 10:40:01PM +0000, Brett Lymn via gnats wrote:
> 
>  On Thu, Feb 13, 2025 at 04:05:02PM +0000, Andreas Gustafsson via gnats wrote:
>  >  
>  >  One remaining oddity is that when sysinst starts and clears the
>  >  screen, it appears to do it three times, first sending 24 copies of
>  >  ^[[K^M, then 24 copies of ^[[C^[[K^M, and finally 24 copies of ^[[K^M
>  >  again.  But maybe that's just sysinst calling curses in strange ways
>  >  rather than a problem with curses itself.
>  >  
>  
>  I will check this but I think the first two are due to the bkgd(stdscr) and then a
>  wbkgd(main). IIRC the bkgd family do an implicit refresh call. Perhaps they should
>  not.
>  

This still happens but I think this is more the way that curses is being
driven by sysinst (I think..)

>  >  Also, the patch is making the drawing of the boxes around the sysinst
>  >  menus slower than it was before.  Without the patch, the horizontal
>  >  lines above and below the menu are drawn by switching to the line
>  >  drawing character set once, then outputting multiple line drawing
>  >  characters, and finally switching back to ASCII.  With the patch, it
>  >  switches back and forth between the line drawing character set and
>  >  ASCII for every line drawing character printed.
>  >  
>   Yes, atf picked that up.  Somehow the acs is being turned on and off per character
>  leading to that noise. I will fix this.
>  

Box drawing is fixed now.

I have committed the fixes to -current so can you please test and let me
know if this is now fixed for you.  I did check the output from sysinst
and it was much saner now.

-- 
Brett Lymn
--
Sent from my NetBSD device.

"We are were wolves",
"You mean werewolves?",
"No we were wolves, now we are something else entirely",
"Oh"