Re: lib/58282: Sysinst terminal output size increased because curses

["Brett Lymn via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR lib/58282; it has been noted by GNATS.

From: Brett Lymn <blymn%internode.on.net@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: lib-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost,
        Andreas Gustafsson <gson%gson.org@localhost>
Subject: Re: lib/58282: Sysinst terminal output size increased because curses
Date: Fri, 14 Feb 2025 07:39:26 +1030

 On Thu, Feb 13, 2025 at 04:05:02PM +0000, Andreas Gustafsson via gnats wrote:
 >  
 >  One remaining oddity is that when sysinst starts and clears the
 >  screen, it appears to do it three times, first sending 24 copies of
 >  ^[[K^M, then 24 copies of ^[[C^[[K^M, and finally 24 copies of ^[[K^M
 >  again.  But maybe that's just sysinst calling curses in strange ways
 >  rather than a problem with curses itself.
 >  
 
 I will check this but I think the first two are due to the bkgd(stdscr) and then a
 wbkgd(main). IIRC the bkgd family do an implicit refresh call. Perhaps they should
 not.
 
 >  Also, the patch is making the drawing of the boxes around the sysinst
 >  menus slower than it was before.  Without the patch, the horizontal
 >  lines above and below the menu are drawn by switching to the line
 >  drawing character set once, then outputting multiple line drawing
 >  characters, and finally switching back to ASCII.  With the patch, it
 >  switches back and forth between the line drawing character set and
 >  ASCII for every line drawing character printed.
 >  
  Yes, atf picked that up.  Somehow the acs is being turned on and off per character
 leading to that noise. I will fix this.
 
 -- 
 Brett Lymn
 --
 Sent from my NetBSD device.
 
 "We are were wolves",
 "You mean werewolves?",
 "No we were wolves, now we are something else entirely",
 "Oh"