NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: install/60334: sysinst(8): partition list is incorrectly updated on UEFI mode when the swap partition is deleted



The following reply was made to PR install/60334; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: install/60334: sysinst(8): partition list is incorrectly updated
 on UEFI mode when the swap partition is deleted
Date: Sun, 21 Jun 2026 23:00:39 +0200

 There is confusion between part_usage_info::flags (which takes
 the PUIFLG_* bits) and is filled like that by the default partition
 data, and part_usage_info::cur_flags which takes PTI_* bits
 from disk_part_info.
 
 However, label.c:renumber_partitions compares info.flags (that is:
 PTI_* bits) with pset->infos[i].flags (that is: PUIFLG_* bits).
 This obviously needs to check pset->infos[i].cur_flags instead.
 
 The code needs to be reviewed for other instances of this confusion.
 
 Martin
 



Home | Main Index | Thread Index | Old Index