NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: bin/60016 (make(1) tests failing since sjg MaybeSubMake changes)



Index: job-output.mk
===================================================================
RCS file: /cvsroot/src/usr.bin/make/unit-tests/job-output.mk,v
retrieving revision 1.2
diff -u -u -r1.2 job-output.mk
--- job-output.mk       13 Jun 2025 06:13:20 -0000      1.2
+++ job-output.mk       28 Feb 2026 20:24:01 -0000
@@ -28,7 +28,7 @@
 # expect: This is stderr.
 # expect: only stderr:
 # expect: end stdout-and-stderr
-stdout-and-stderr:
+stdout-and-stderr: .MAKE
        @echo begin $@
        @echo only stdout:
        @${MAKE} -f ${MAKEFILE} echo-on-stdout-and-stderr 2>/dev/null


christos

> On Feb 24, 2026, at 7:20 PM, Simon J. Gerraty via gnats <gnats-admin%netbsd.org@localhost> wrote:
> 
> The following reply was made to PR bin/60016; it has been noted by GNATS.
> 
> From: "Simon J. Gerraty" <sjg%juniper.net@localhost>
> To: <gnats-bugs%netbsd.org@localhost>
> Cc: <gnats-admin%netbsd.org@localhost>, <netbsd-bugs%netbsd.org@localhost>, <riastradh%netbsd.org@localhost>,
>        <campbell+netbsd%mumble.net@localhost>, <rillig%netbsd.org@localhost>, <sjg%juniper.net@localhost>
> Subject: Re: bin/60016 (make(1) tests failing since sjg MaybeSubMake changes)
> Date: Tue, 24 Feb 2026 15:47:49 -0800
> 
> riastradh%netbsd.org@localhost wrote:
>> Synopsis: make(1) tests failing since sjg MaybeSubMake changes
>> Can you please take a look?
> 
> I'm not able to reproduce as I don't have any i386 netbsd box
> and my two amd64 boxes (here and at home) are currently dead - long sad
> story.
> 
> I've also had zero luck trying to get netbsd to boot in a vm (bhyve) so
> if anyone has a clue to offer that would be great.
> 
> I don't see how atf-run would make any difference, the job-output test
> itself passes on darwin, linux, and freebsd.
> 
> I also just checked that the way atf-run is running the tests should be
> fine: =
> 
> 
> $ cd /tmp
> $ mkdir obj
> $ MAKEOBJDIR=3Dobj make -f /homes/sjg/work/NetBSD/current/src/usr.bin/make=
> /unit-tests/Makefile job-output.out
> $ diff obj/job-output.out /homes/sjg/work/NetBSD/current/src/usr.bin/make/=
> unit-tests/job-output.exp
> $
> 
> I'll have another go with vm...
> 

Attachment: signature.asc
Description: Message signed with OpenPGP



Home | Main Index | Thread Index | Old Index