NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

PR/59997 CVS commit: src/sys/dev/usb



The following reply was made to PR kern/59997; it has been noted by GNATS.

From: "David H. Gutteridge" <gutteridge%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/59997 CVS commit: src/sys/dev/usb
Date: Wed, 25 Feb 2026 01:34:14 +0000

 Module Name:	src
 Committed By:	gutteridge
 Date:		Wed Feb 25 01:34:14 UTC 2026
 
 Modified Files:
 	src/sys/dev/usb: if_ure.c
 
 Log Message:
 if_ure.c: make hardware capabilities test work as intended
 
 As originally coded, the test intended to not set certain checksum
 offload capabilities for the oldest RTL8152 chip revision couldn't
 actually take effect. (The Realtek 4C00 device is an 8152 chipset,
 thus URE_FLAG_8152 is also set, and the bitwise complement of
 URE_FLAG_VER_4C00 isn't sufficient to test what's intended there.)
 
 While here, also remove an inconsistently-applied INET6 check. Half the
 relevant capabilities weren't guarded, and no other driver in our tree
 guards IPv6 hardware checksumming this way, so follow suit here and
 avoid the potential confusion/inconsistency.
 
 Addresses PR kern/59997. Thanks to kre@ for significant input here.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.62 -r1.63 src/sys/dev/usb/if_ure.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 


Home | Main Index | Thread Index | Old Index