Re: kern/59997: if_ure.c has a check to avoid setting hardware capabilities that's impossible to satisfy

["Robert Elz via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR kern/59997; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/59997: if_ure.c has a check to avoid setting hardware capabilities that's impossible to satisfy
Date: Fri, 13 Feb 2026 01:18:52 +0700

     Date:        Thu, 12 Feb 2026 01:20:01 +0000 (UTC)
     From:        "david%gutteridge.ca@localhost via gnats" <gnats-admin%NetBSD.org@localhost>
     Message-ID:  <20260212012001.340281A923D%mollari.NetBSD.org@localhost>
 
 
   | Presumably this test should really be:
   |
   | if (un->un_flags & ~(URE_FLAG_8152 | URE_FLAG_VER_4C00)) {
 
 I have none of those, and know nothing about them at all, but
 it looks to me as if the what the test probably really intended
 was
 
 	if (!(un->un_flags & URE_FLAG_VER_4C00)) {
 
 That is, if it is not a 4C00 (using the original to test for that
 state is simply bizarre, but is also the kind of thing easy to do).
 
 But there is more odd code around there ... the transmit offload
 capabilities for v6 are only set if INET6 is defined (which is
 reasonable) but the similar receive capabilities are set unconditionally
 (except for the above test) which makes little sense to me.
 
 kre