NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

PR/59942 CVS commit: src/bin/dd



The following reply was made to PR bin/59942; it has been noted by GNATS.

From: "Robert Elz" <kre%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/59942 CVS commit: src/bin/dd
Date: Mon, 26 Jan 2026 08:37:30 +0000

 Module Name:	src
 Committed By:	kre
 Date:		Mon Jan 26 08:37:29 UTC 2026
 
 Modified Files:
 	src/bin/dd: args.c dd.1 dd.c
 
 Log Message:
 PR bin/59942 Fix handling of count=0
 
 Apply (modified) patch from Andrus Suvalau in PR bin/59942
 (The actual change is very simple)
 
 This looks to have been broken since version 1.1 - simply short
 circuiting processing because count==0 is wrong, there is much
 else that needs to be done before copying nothing (including
 verifying args that follow it).
 
 It is almost certain that files=0 will need a similar change.
 That one looks like it will be even easier - simply deleting
 the test for files_cnt being 0 in args.c/f_files() should be
 enough I believe - but as I haven't seen any system with a
 tape drive in decades, I am unable to test any changes properly,
 so I will leave that to someone who can test it properly.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.43 -r1.44 src/bin/dd/args.c
 cvs rdiff -u -r1.38 -r1.39 src/bin/dd/dd.1
 cvs rdiff -u -r1.53 -r1.54 src/bin/dd/dd.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 


Home | Main Index | Thread Index | Old Index