Re: PR/57807 CVS commit: src/sys/sys

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

> Date: Wed, 25 Sep 2024 15:28:48 +0900
> From: Rin Okuyama <rokuyama.rk%gmail.com@localhost>
> 
> On amd64 host with this commit for endian.h, cross-build for
> evbarmv7hf-eb (at least) fails as follows:
> 
> ````
> % uname -a
> NetBSD sakaizumii.local 10.99.12 NetBSD 10.99.12 (AMD64_NET_MPSAFE) #0: 
> Sun Sep 22 10:03:08 JST 2024 
> rin@sakaizumii.local:/home/rin/src/sys/arch/amd64/compile/AMD64_NET_MPSAFE 
> amd64
> % head -1 /usr/include/sys/endian.h
> /*      $NetBSD: endian.h,v 1.35 2024/09/09 18:38:38 rillig Exp $       */
> % cd src/tools/libctf && nbmake-evbarmv7hf-eb
> ...
> In file included from 
> /home/rin/build.pullup-0925/tools/include/compat/nbtool_config.h:931,
>                   from 
> /home/rin/src/tools/libctf/../../external/cddl/osnet/dist/
> common/ctf/ctf_create.c:23:
> /home/rin/src/tools/libctf/../compat/compat_defs.h:1148:22: error: 
> redefinition of 'be16enc'
> ...
> ````
> 
> This can be worked around by reverting rev 1.34 only.

Does this failure still reproduce after christos's fix to osnet
sys/types.h?

https://mail-index.netbsd.org/source-changes/2024/09/11/msg153276.html

> The failure occurs because:
> (1) During configure in tools/compat, _NETBSD_SOURCE is disabled.
> (2) For other tools build, _NETBSD_SOURCE is defined.

_NETBSD_SOURCE should absolutely never be defined during any part of
the tools build, and it was a mistake for it to appear in the osnet
sys/types.h hacks.

If christos's change doesn't fix it, can you find where _NETBSD_SOURCE
is getting defined so we can fix that too?