Re: toolchain/58663: gpt(1) biosboot.c doesn't compile on modern Linux

[" Jason Thorpe via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR toolchain/58663; it has been noted by GNATS.

From: Jason Thorpe <thorpej%me.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: toolchain-manager%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost,
 Lloyd Parkes <lloyd%must-have-coffee.gen.nz@localhost>
Subject: Re: toolchain/58663: gpt(1) biosboot.c doesn't compile on modern
 Linux
Date: Wed, 4 Sep 2024 06:31:47 -0700

 > On Sep 3, 2024, at 9:35=E2=80=AFPM, matthew green via gnats =
 <gnats-admin%NetBSD.org@localhost> wrote:
 >=20
 > The following reply was made to PR toolchain/58663; it has been noted =
 by GNATS.
 >=20
 > From: matthew green <mrg%eterna23.net@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: toolchain-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 >    netbsd-bugs%netbsd.org@localhost
 > Subject: re: toolchain/58663: gpt(1) biosboot.c doesn't compile on =
 modern Linux
 > Date: Wed, 04 Sep 2024 14:33:04 +1000
 >=20
 >> -       daddr_t start =3D 0;
 >> +       off_t start =3D 0;        /* off_t because of gpt_human_get() =
 */
 >=20
 > i think your change is generally correct, but it really indicates
 > it much larger problem.
 >=20
 > daddr_t should be made to be 64-bit. (except for the cases where =
 netbsd
 > is building 32-bit daddr_t values for eg, old platform boot programs.)
 
 Be careful .. it certainly used to be the case that daddr_t was used in =
 on-disk structure definitions in e.g. UFS.
 
 -- thorpej