PR/56252 CVS commit: src/sys/net

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

The following reply was made to PR kern/56252; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/56252 CVS commit: src/sys/net
Date: Sun, 28 Jul 2024 14:38:43 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sun Jul 28 14:38:42 UTC 2024
 
 Modified Files:
 	src/sys/net: if_wg.c
 
 Log Message:
 wg(4): Use callout_halt, not callout_stop.
 
 It's possible that callout_stop might work here, but let's simplify
 reasoning about it -- the timers in question only take the peer intr
 lock, so it's safe to wait for them while holding the peer lock in
 the handshake worker thread.
 
 We may have to undo the task bit but that will take a bit more
 analysis to determine.
 
 Prompted by (but probably won't fix anything in):
 
 PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails
 PR kern/56252: wg(4) state machine has race conditions
 PR kern/58463: if_wg does not work when idle.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.95 -r1.96 src/sys/net/if_wg.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.