PR/56252 CVS commit: src/sys/net

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

The following reply was made to PR kern/56252; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/56252 CVS commit: src/sys/net
Date: Sun, 28 Jul 2024 14:39:00 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sun Jul 28 14:39:00 UTC 2024
 
 Modified Files:
 	src/sys/net: if_wg.c
 
 Log Message:
 wg(4): Omit needless pserialize_perform on transition to DESTROYING.
 
 A session can still be used when it is in the DESTROYING state, so
 there's no need to wait for users to drain here -- that's the whole
 point of a separate DESTROYING state.
 
 It is only the transition from DESTROYING back to UNKNOWN, after the
 session has been unpublished so no new users can begin, that requires
 waiting for all users to drain, and we already do that in
 wg_destroy_session.
 
 Prompted by (but won't fix anything in, because this is just a
 performance optimization):
 
 PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails
 PR kern/56252: wg(4) state machine has race conditions
 PR kern/58463: if_wg does not work when idle.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.96 -r1.97 src/sys/net/if_wg.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.