NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/58335 (Kernel panic when shutting down a virtual machine with Virtio devices)
The following reply was made to PR kern/58335; it has been noted by GNATS.
From: Taylor R Campbell <campbell%mumble.net@localhost>
To: =?UTF-8?Q?Roddy_Gonz=C3=A1lez?= <roddy.gonzalez.89%gmail.com@localhost>
Cc: gnats-bugs%netbsd.org@localhost, kern-bug-people%netbsd.org@localhost,
netbsd-bugs%netbsd.org@localhost, gnats-admin%netbsd.org@localhost
Subject: Re: kern/58335 (Kernel panic when shutting down a virtual machine
with Virtio devices)
Date: Wed, 26 Jun 2024 14:39:05 +0000
This is a multi-part message in MIME format.
--=_ml7q+P8YFLTA7qSAPcDHHBHCSIXmg0yj
Thanks! Looks like we have another bug, and that one's a little more
work to deal with.
Can you try reverting this change?
https://mail-index.netbsd.org/source-changes/2024/06/25/msg151955.html
That change disables access to a code path, but I want to see if I
fixed that code path too.
--=_ml7q+P8YFLTA7qSAPcDHHBHCSIXmg0yj
Content-Type: text/plain; charset="ISO-8859-1"; name="virtio_shutdown"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment; filename="virtio_shutdown.patch"
diff --git a/sys/dev/pci/virtio_pci.c b/sys/dev/pci/virtio_pci.c
index 5ede6a6c448a..30e30721e23e 100644
--- a/sys/dev/pci/virtio_pci.c
+++ b/sys/dev/pci/virtio_pci.c
@@ -174,7 +174,7 @@ static bool virtio_pci_msix_enabled(struct virtio_pci_s=
oftc *);
=20
CFATTACH_DECL3_NEW(virtio_pci, sizeof(struct virtio_pci_softc),
virtio_pci_match, virtio_pci_attach, virtio_pci_detach, NULL,
- virtio_pci_rescan, NULL, 0);
+ virtio_pci_rescan, NULL, DVF_DETACH_SHUTDOWN);
=20
static const struct virtio_ops virtio_pci_ops_09 =3D {
.kick =3D virtio_pci_kick_09,
--=_ml7q+P8YFLTA7qSAPcDHHBHCSIXmg0yj--
Home |
Main Index |
Thread Index |
Old Index