Re: kern/58335 (Kernel panic when shutting down a virtual machine with Virtio devices)

[Taylor R Campbell <campbell%mumble.net@localhost>]

Thanks!  Looks like we have another bug, and that one's a little more
work to deal with.

Can you try reverting this change?

https://mail-index.netbsd.org/source-changes/2024/06/25/msg151955.html

That change disables access to a code path, but I want to see if I
fixed that code path too.

diff --git a/sys/dev/pci/virtio_pci.c b/sys/dev/pci/virtio_pci.c
index 5ede6a6c448a..30e30721e23e 100644
--- a/sys/dev/pci/virtio_pci.c
+++ b/sys/dev/pci/virtio_pci.c
@@ -174,7 +174,7 @@ static bool	virtio_pci_msix_enabled(struct virtio_pci_softc *);
 
 CFATTACH_DECL3_NEW(virtio_pci, sizeof(struct virtio_pci_softc),
     virtio_pci_match, virtio_pci_attach, virtio_pci_detach, NULL,
-    virtio_pci_rescan, NULL, 0);
+    virtio_pci_rescan, NULL, DVF_DETACH_SHUTDOWN);
 
 static const struct virtio_ops virtio_pci_ops_09 = {
 	.kick = virtio_pci_kick_09,