re: port-vax/58261

[matthew green <mrg%eterna23.net@localhost>]

The following reply was made to PR port-vax/58261; it has been noted by GNATS.

From: matthew green <mrg%eterna23.net@localhost>
To: David Brownlee <abs%absd.org@localhost>
Cc: port-vax-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
    netbsd-bugs%netbsd.org@localhost, ncommander@restless.systems,
    gnats-bugs%netbsd.org@localhost, port-vax List <port-vax%netbsd.org@localhost>
Subject: re: port-vax/58261
Date: Mon, 10 Jun 2024 04:37:23 +1000

 > https://sync.absd.org/vax/vax-sie.diff (also via http:// for those who
 
 thanks for working on this.  looks pretty good to me.
 
 couple of minor comments:
 
 - switch is a keyword, so add/retain the spaces after it before the (.
 - ka46.c change could do with a line wrap to retain 80 cols
 - VAX_BTYP_46 check now assumes not 1 is 2, instead of checking for 1,
   2, and then deciding unknown.  also VAX_BTYP_48.  also VAX_BTYP_420
   for 0 and 1..
 - if you want to clean up a little more, changing these '1', '2', etc.,
   magic numbers could be named, "vax_cpudata & 0xff" could become a
   macro (GET_SIE_MICROCODE_VER(x)?)
 
 
 .mrg.