NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
re: port-vax/58261
> https://sync.absd.org/vax/vax-sie.diff (also via http:// for those who
thanks for working on this. looks pretty good to me.
couple of minor comments:
- switch is a keyword, so add/retain the spaces after it before the (.
- ka46.c change could do with a line wrap to retain 80 cols
- VAX_BTYP_46 check now assumes not 1 is 2, instead of checking for 1,
2, and then deciding unknown. also VAX_BTYP_48. also VAX_BTYP_420
for 0 and 1..
- if you want to clean up a little more, changing these '1', '2', etc.,
magic numbers could be named, "vax_cpudata & 0xff" could become a
macro (GET_SIE_MICROCODE_VER(x)?)
.mrg.
Home |
Main Index |
Thread Index |
Old Index