Re: lib/58282: Sysinst terminal output size increased because curses

[Valery Ushakov <uwe%stderr.spb.ru@localhost>]

The following reply was made to PR lib/58282; it has been noted by GNATS.

From: Valery Ushakov <uwe%stderr.spb.ru@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: Brett Lymn <blymn%NetBSD.org@localhost>
Subject: Re: lib/58282: Sysinst terminal output size increased because curses
Date: Sun, 26 May 2024 05:16:20 +0300

 [cc'ing Brett]
 
 makech() in refresh.c has a block of code with the comment:
 
   Work out if we can use a clear to end of line.  If we are using
   color then we can only erase the line if the terminal can erase to
   the background color.
 
 it uses (for the HAVE_WIDE case, which is the defautl) the helper
 function _cursesi_celleq() that also checks if "attr" is the same, but
 the next test in the condition narrows the attr comparison to
 attr_mask.  That looks suspicious.
 
 PS: While there...
 
 static __LDATA blank; probably should not be static.
 
 And for the love of goodness, please, can we keep the parens balanced
 inside/outside ifdefs? :)
 
 -uwe