lib/58282: Sysinst terminal output size increased because curses

[gson%gson.org@localhost (Andreas Gustafsson)]

>Number:         58282
>Category:       lib
>Synopsis:       Sysinst terminal output size increased because curses
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 25 12:45:00 +0000 2024
>Originator:     Andreas Gustafsson
>Release:        NetBSD-current, source date >= 2022.04.12.07.03.29
>Organization:
  
>Environment:
System: NetBSD
Architecture: i386
Machine: i386
>Description:

According to the logs from the TNF i386 testbed, the amount of data
output to the terminal when performing a serial console installation
using sysinst(1) more than doubled after these commits:

  2022.04.12.07.03.04 blymn src/lib/libcurses/add_wchstr.c 1.12
  2022.04.12.07.03.04 blymn src/lib/libcurses/addbytes.c 1.62
  2022.04.12.07.03.04 blymn src/lib/libcurses/attributes.c 1.34
  2022.04.12.07.03.04 blymn src/lib/libcurses/background.c 1.29
  2022.04.12.07.03.04 blymn src/lib/libcurses/border.c 1.23
  2022.04.12.07.03.04 blymn src/lib/libcurses/clrtobot.c 1.29
  2022.04.12.07.03.04 blymn src/lib/libcurses/clrtoeol.c 1.34
  2022.04.12.07.03.04 blymn src/lib/libcurses/color.c 1.46
  2022.04.12.07.03.04 blymn src/lib/libcurses/copywin.c 1.21
  2022.04.12.07.03.04 blymn src/lib/libcurses/curses_private.h 1.78
  2022.04.12.07.03.04 blymn src/lib/libcurses/delch.c 1.28
  2022.04.12.07.03.04 blymn src/lib/libcurses/erase.c 1.35
  2022.04.12.07.03.04 blymn src/lib/libcurses/get_wstr.c 1.11
  2022.04.12.07.03.04 blymn src/lib/libcurses/ins_wch.c 1.19
  2022.04.12.07.03.04 blymn src/lib/libcurses/ins_wstr.c 1.23
  2022.04.12.07.03.04 blymn src/lib/libcurses/insdelln.c 1.21
  2022.04.12.07.03.04 blymn src/lib/libcurses/mvwin.c 1.24
  2022.04.12.07.03.04 blymn src/lib/libcurses/newwin.c 1.66
  2022.04.12.07.03.04 blymn src/lib/libcurses/refresh.c 1.119
  2022.04.12.07.03.04 blymn src/lib/libcurses/shlib_version 1.47
  2022.04.12.07.03.04 blymn src/lib/libcurses/slk.c 1.20
  2022.04.12.07.03.04 blymn src/lib/libcurses/touchwin.c 1.34
  2022.04.12.07.03.29 blymn src/distrib/sets/lists/base/shl.mi 1.934

Looks like the optimization performed by curses got less optimal.

Here are copies of the installation console logs from before and after
the above commits for comparison:

  https://www.gson.org/netbsd/bugs/curses/2022.04.11.21.23.07-install.log
  https://www.gson.org/netbsd/bugs/curses/2022.04.12.07.03.29-install.log

The relevant part starts after the line saying
"erase ^?, werase ^W, kill ^U, intr ^C".

>How-To-Repeat:

>Fix: