NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: PR/58201 CVS commit: src/sys/dev/acpi

The following reply was made to PR kern/58201; it has been noted by GNATS.

From: Christos Zoulas <christos%zoulas.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: kern-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost,
 Malte Dehling <mdehling%gmail.com@localhost>
Subject: Re: PR/58201 CVS commit: src/sys/dev/acpi
Date: Fri, 26 Apr 2024 17:41:42 -0400

 --Apple-Mail=_251F196E-3EE1-4F64-97BF-03C62896E190
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=utf-8
 
 
 
 > On Apr 26, 2024, at 4:35=E2=80=AFPM, Malte Dehling =
 <mdehling%gmail.com@localhost> wrote:
 >=20
 > The following reply was made to PR kern/58201; it has been noted by =
 GNATS.
 >=20
 > The call to sysmon_envsys_register() will trigger an initial refresh =
 and
 > the refresh function looks at sc->sc_last which is uninitialized since
 > acpibat_update_status() hasn't been called yet.
 >=20
 
 It is zeroed, so it should return immediately, right?
 Perhaps I should add a memset to it since acpi_bat.c
 zero's some of the fields explicitly anyway (but it should not need to).
 
 https://nxr.netbsd.org/xref/src/sys/kern/subr_autoconf.c#1591
 
 christos=
 
 --Apple-Mail=_251F196E-3EE1-4F64-97BF-03C62896E190
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/html;
 	charset=utf-8
 
 <html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
 charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
 -webkit-nbsp-mode: space; line-break: after-white-space;"><br =
 id=3D"lineBreakAtBeginningOfMessage"><div><br><blockquote =
 type=3D"cite"><div>On Apr 26, 2024, at 4:35=E2=80=AFPM, Malte Dehling =
 &lt;mdehling%gmail.com@localhost&gt; wrote:</div><br =
 class=3D"Apple-interchange-newline"><div><div>The following reply was =
 made to PR kern/58201; it has been noted by GNATS.<br><br> The call to =
 sysmon_envsys_register() will trigger an initial refresh and<br> the =
 refresh function looks at sc-&gt;sc_last which is uninitialized =
 since<br> acpibat_update_status() hasn't been called =
 yet.<br><br></div></div></blockquote><div><br></div>It is zeroed, so it =
 should return immediately, right?</div><div>Perhaps I should add a =
 memset to it since acpi_bat.c</div><div>zero's some of the fields =
 explicitly anyway (but it should not need =
 to).</div><div><br></div><div><a =
 href=3D"https://nxr.netbsd.org/xref/src/sys/kern/subr_autoconf.c#1591";>htt=
 ps://nxr.netbsd.org/xref/src/sys/kern/subr_autoconf.c#1591</a><div><br></d=
 iv></div>christos</body></html>=
 
 --Apple-Mail=_251F196E-3EE1-4F64-97BF-03C62896E190--
Home | Main Index | Thread Index | Old Index