Re: Re: PR/58201 CVS commit: src/sys/dev/acpi

[Malte Dehling <mdehling%gmail.com@localhost>]

The following reply was made to PR kern/58201; it has been noted by GNATS.

From: Malte Dehling <mdehling%gmail.com@localhost>
To: GNATS Bugs <gnats-bugs%netbsd.org@localhost>
Cc: 
Subject: Re: Re: PR/58201 CVS commit: src/sys/dev/acpi
Date: Fri, 26 Apr 2024 16:39:35 -0700

 --000000000000a0c8f00617086aaa
 Content-Type: text/plain; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable
 
 On Fri, Apr 26, 2024 at 05:41:42PM -0400, Christos Zoulas wrote:
 > > On Apr 26, 2024, at 4:35=E2=80=AFPM, Malte Dehling <mdehling%gmail.com@localhost>=
  wrote:
 > > The call to sysmon_envsys_register() will trigger an initial refresh an=
 d
 > > the refresh function looks at sc->sc_last which is uninitialized since
 > > acpibat_update_status() hasn't been called yet.
 >
 > It is zeroed, so it should return immediately, right?
 > Perhaps I should add a memset to it since acpi_bat.c
 > zero's some of the fields explicitly anyway (but it should not need to).
 
 Thanks, you're right!  I didn't realize the softc struct is zeroed.
 
 So with refresh returning immediately, the initial limits will be 0 and
 updated with the following call to acpibat_update_info.  That seems safe
 to me.  Should we get rid of SME_INIT_REFRESH to avoid the unnecessary
 refresh call?
 
 --=20
 Malte Dehling
 
 --000000000000a0c8f00617086aaa
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Disposition: attachment; filename="signature.asc"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: 4edad17c2d048f0c_0.1
 
 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUFCQ0FBZEZpRUVva3ZsOUFOMEFo
 T05jQXdlSzhMazZxS3dkMFFGQW1Zc095OEFDZ2tRSzhMazZxS3cKZDBUNFZSQUFySlB4dElzR1Nh
 Nm01WjFOYXdWOExNUjE2ck5td1hpR2JFSmg2SmJLTUZqUzVLRU1NNk4za1hybApVa2w5Wkl3YWRj
 a3JQK0VFRFN1dFNEZ2xWVC9YTVI4bW40WGFrcFU1V2wwS09kM1FtSXR5anVuMW9CbDkrcHBxClgw
 djNselpRY2lMWDJNNFoxVUx3NWRnQk5kTzRmK0ZaZW9SOGN1QlByeUVKNWtsRHVjbm13d21MNk1F
 TDc1bVYKMzBGZUdRU0dxb09ENGhlNEFlcXZlTDZQUFlTRGVuZDQrckZmOEo1aDRrZFFYMWx3Z3l5
 R3lFZFVXUE9WNVh4RwptQklyNHRsSCt1WThpTFdyMERUVEV2enNVZEc4YTZhcHVVUkRhNUVnbmNw
 UzNhZWh1R0VYdWlpR0dkQXdXdHpUCk51RFA4amtMczVYV0svUGJnN0c1VTZvcDNGV3E0YVROZkcz
 QVVRSGt0RFBDa2F0aUhQK0NLMllvaktUZUIrTEEKUzdpdTVPeU5TSFNEclNVVlp5MTBBdEUwQzlE
 NjRLWExob01RbTkyc25lZ3ZwL3J5cm1EdkN6ZVVKVFBnUzJxZApxU1hmMFd4S2lyVzNHdDhBSjhy
 M2w3akxhci9qUHRmMXZZK0FJbkRNRWVHeE52NjNBL2NIMTFJTDhYeEc4N2tsCkI1MGJUMDZjdzFs
 cjV4NnIvZFZpeTRXeWJKTUlRSnZobjNKbytCdnF4RFVhdGV5ejZQaUpXMHlsY2x3UmEzMUkKTWk1
 MW1pUU5hRE5SNUF2MUR5YlRTYlVPRkIzZ1NFMzBMMmc1MG5tVmF1UEIxeGVRY2phU0JWeE9xN2Qx
 SEhZdApFMk9VaEtpRTd4c0FxWFk2eXBQUVNjUFN0WXNJR1cyK2JyYU5LcWx3VUpldUorY2YxQWc9
 Cj0wcWRYCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=
 --000000000000a0c8f00617086aaa--