Re: kern/57959: icmp6_reflect prints confusing error message to console without attribution

[mlelstv%serpens.de@localhost (Michael van Elst)]

The following reply was made to PR kern/57959; it has been noted by GNATS.

From: mlelstv%serpens.de@localhost (Michael van Elst)
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/57959: icmp6_reflect prints confusing error message to console without attribution
Date: Sat, 24 Feb 2024 08:14:24 -0000 (UTC)

 campbell+netbsd%mumble.net@localhost writes:
 
 >It is completely obscure what is going on here.  Grepping through the source code I find this message:
 
 >https://nxr.netbsd.org/xref/src/sys/netinet6/icmp6.c?r=1.255#2175
 
 >   2175 			char ip6buf[INET6_ADDRSTRLEN];
 >   2176 			nd6log(LOG_DEBUG,
 >   2177 			    "source can't be determined: "
 >   2178 			    "dst=%s, error=%d\n",
 >   2179 			    IN6_PRINT(ip6buf, &sin6.sin6_addr), e);
 >   2180 			goto bad;
 
 
 It's arp, not nd6.
 
 static void 
 arp_llinfo_output(struct ifnet *ifp, __unused const union l3addr *daddr,
     const union l3addr *taddr, const uint8_t *tlladdr,
     const union l3addr *hsrc)
 {
 	...
                 if (sip.s_addr == INADDR_ANY) {
                         char ipbuf[INET_ADDRSTRLEN];
  
                         log(LOG_DEBUG, "source can't be "
                             "determined: dst=%s\n",
                             IN_PRINT(ipbuf, &tip));
                         return;
                 }
 	...
 }
 
 Maybe:
 
 --- if_arp.c    15 Nov 2022 10:47:39 -0000      1.311
 +++ if_arp.c    24 Feb 2024 08:13:54 -0000
 @@ -1355,8 +1355,8 @@ arp_llinfo_output(struct ifnet *ifp, __u
                 if (sip.s_addr == INADDR_ANY) {
                         char ipbuf[INET_ADDRSTRLEN];
  
 -                       log(LOG_DEBUG, "source can't be "
 -                           "determined: dst=%s\n",
 +                       log(LOG_DEBUG, "%s: source can't be "
 +                           "determined: dst=%s\n", __func__,
                             IN_PRINT(ipbuf, &tip));
                         return;
                 }
 
 to align with the other debug log messages.