NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: bin/57682 (Check if suplied argument(s) has "-" using only argument vectors instead calling strcmp() function.)



Synopsis: Check if suplied argument(s) has "-" using only argument vectors instead calling strcmp() function.

State-Changed-From-To: open->closed
State-Changed-By: kre%NetBSD.org@localhost
State-Changed-When: Tue, 07 Nov 2023 12:11:37 +0000
State-Changed-Why:
The first (main) issue is simply wrong (and even if it had been correct,
making a change like that to shave a few microseconds off the time it
takes cat to parse its args would be pointless) - the second (minor) issue
isn't something that we worry about (there would be almost countless
similar instances throughout the tree).

If you have any doubts as to the first change being wrong, try something
like
	cp /etc/motd -file
	yourcat -- -file
with your modified sources, and see what happens.  (rm ./-file afterwards).





Home | Main Index | Thread Index | Old Index