Re: port-arm/57324: NetBSD 10.99.2 -current fails to detect root wedge using name on Raspberry Pi 3 official image

[sc.dying%gmail.com@localhost]

The following reply was made to PR port-arm/57324; it has been noted by GNATS.

From: sc.dying%gmail.com@localhost
To: gnats-bugs%netbsd.org@localhost, port-arm-maintainer%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost, bbartlomiej.mail%gmail.com@localhost
Cc: 
Subject: Re: port-arm/57324: NetBSD 10.99.2 -current fails to detect root
 wedge using name on Raspberry Pi 3 official image
Date: Fri, 27 Oct 2023 23:34:39 +0000

 On 2023/10/27 21:05, matthew green wrote:
 > The following reply was made to PR port-arm/57324; it has been noted by GNATS.
 > 
 > From: matthew green <mrg%eterna.com.au@localhost>
 > To: sc.dying%gmail.com@localhost, bbartlomiej.mail%gmail.com@localhost
 > Cc: gnats-bugs%netbsd.org@localhost, port-arm-maintainer%netbsd.org@localhost,
 >     gnats-admin%netbsd.org@localhost
 > Subject: re: port-arm/57324: NetBSD 10.99.2 -current fails to detect root wedge using name on Raspberry Pi 3 official image
 > Date: Sat, 28 Oct 2023 08:01:25 +1100
 > 
 >  sc.dying%gmail.com@localhost writes:
 >  > On 2023/04/05 20:30, bbartlomiej.mail%gmail.com@localhost wrote:
 >  > > [   3.2258697] boot device: ld0
 >  > > [   3.2369263] root on ld0a dumps on ld0b
 >  > > [   3.2369263] vfs_mountroot: can't open root device
 >  > > [   3.2369263] cannot mount root, error = 16
 >  >
 >  > I've confirmed that NetBSD-current/evbarm-aarch64 cannot detect root
 >  > device correctly, and now NetBSD-10.0_BETA/evbarm-aarch64 (202310212330Z)
 >  > fails to detect root device correctly after arch/evbarm/evbarm/autoconf.c
 >  > changes on 20 Oct.
 >  
 >  hmmm, i thought that mlelstv's fdt_machdep.c revision 1.101 fixed that,
 >  but i guess there's a problem still.
 >  
 >  root detection is finding the real device, but in the above case it is
 >  choosing disklabel/mbr style naming, when this doesn't have a label,
 >  but should be choosing the wedge (dkN).
 >  
 >  i wonder if the problem is actually in init_main.c's
 >  rootconf_handle_wedges() where it tries to use booted_partition if
 >  booted_nblks == 0, and i see that it also wants booted_startblk set,
 >  but evbarm doesn't set these of these, only booted_device, where as
 >  here booted_device already is correctly set.
 >  
 >  does this reproduce easily in eg qemu?  also what things in /chosen
 >  are called either "netbsd,gpt-guid" or "netbsd,gpt-label" here?
 >  one or the other needs to exist for gpt disk boot.
 
 Trying netbsd-10 202310212330Z on real hardware rpi3b...
 (I fotgot to mention that I confirmed on Raspberry Pi 3 Model B Rev 1.2.)
 
 [...]
 [   3.0306229] boot device: ld0
 [   3.0306229] root on ld0a dumps on ld0b
 [   3.0306229] vfs_mountroot: can't open root device
 [   3.0406234] cannot mount root, error = 16
 [   3.0406234] root device (default ld0a): ?
 [  81.1066879] use one of: dk0 dk1 ld0[a-p] bwfm0 usmsc0 wedge:EFI wedge:netbsd-root ddb halt reboot
 [  81.1166888] root device (default ld0a): wedge:netbsd-root
 [ 136.4110312] dump device:
 [ 140.3113460] file system (default generic):
 [ 141.0113947] root on dk1
 [ 141.0313958] root file system type: ffs
 [ 141.0313958] kern.module.path=/stand/evbarm/10.0/modules
 [...resize, reboot, and login...]
 arm64# ofctl /chosen
 [Caching 120 nodes and 768 properties]
 bootargs                62636d32 3730385f 66622e66 62776964   bcm2708_fb.fbwid
             0010:       74683d36 35362062 636d3237 30385f66   th=656 bcm2708_f
             0020:       622e6662 68656967 68743d34 31362062   b.fbheight=416 b
             0030:       636d3237 30385f66 622e6662 73776170   cm2708_fb.fbswap
             0040:       3d312064 6d612e64 6d616368 616e733d   =1 dma.dmachans=
             0050:       30783766 33352062 636d3237 30392e62   0x7f35 bcm2709.b
             0060:       6f617264 7265763d 30786132 32303832   oardrev=0xa22082
             0070:       2062636d 32373039 2e736572 69616c3d    bcm2709.serial=
             0080:       30783161 61383461 65382062 636d3237   0x1aa84ae8 bcm27
             0090:       30392e75 6172745f 636c6f63 6b3d3438   09.uart_clock=48
             00a0:       30303030 30302073 6d736339 3578782e   000000 smsc95xx.
             00b0:       6d616361 6464723d 42383a32 373a4542   macaddr=B8:27:EB
             00c0:       xxxxxxxx xxxxxxxx 38207663 5f6d656d   xxxxxxxx8 vc_mem
             00d0:       2e6d656d 5f626173 653d3078 33656330   .mem_base=0x3ec0
             00e0:       30303030 2076635f 6d656d2e 6d656d5f   0000 vc_mem.mem_
             00f0:       73697a65 3d307834 30303030 30303020   size=0x40000000
             0100:       20726f6f 743d4e41 4d453d6e 65746273    root=NAME=netbs
             0110:       642d726f 6f742063 6f6e736f 6c653d66   d-root console=f
             0120:       6200.... ........ ........ ........   b.
 kaslr-seed              9b472506 209a0f6b ........ ........   .G%. ..k
 name                    63686f73 656e00.. ........ ........   "chosen"
 stdout-path             73657269 616c313a 31313532 30306e38   serial1:115200n8
             0010:       00...... ........ ........ ........   .
 arm64#
 
 Not seem to have prop netbsd,gpt-guid or netbsd,gpt-label.
 Do I do correct command?
 
 >  
 >  thanks.
 >  
 >  
 >  .mrg.
 >