re: port-arm/57324: NetBSD 10.99.2 -current fails to detect root wedge using name on Raspberry Pi 3 official image

[matthew green <mrg%eterna.com.au@localhost>]

The following reply was made to PR port-arm/57324; it has been noted by GNATS.

From: matthew green <mrg%eterna.com.au@localhost>
To: sc.dying%gmail.com@localhost, bbartlomiej.mail%gmail.com@localhost
Cc: gnats-bugs%netbsd.org@localhost, port-arm-maintainer%netbsd.org@localhost,
    gnats-admin%netbsd.org@localhost
Subject: re: port-arm/57324: NetBSD 10.99.2 -current fails to detect root wedge using name on Raspberry Pi 3 official image
Date: Sat, 28 Oct 2023 08:01:25 +1100

 sc.dying%gmail.com@localhost writes:
 > On 2023/04/05 20:30, bbartlomiej.mail%gmail.com@localhost wrote:
 > > [   3.2258697] boot device: ld0
 > > [   3.2369263] root on ld0a dumps on ld0b
 > > [   3.2369263] vfs_mountroot: can't open root device
 > > [   3.2369263] cannot mount root, error = 16
 >
 > I've confirmed that NetBSD-current/evbarm-aarch64 cannot detect root
 > device correctly, and now NetBSD-10.0_BETA/evbarm-aarch64 (202310212330Z)
 > fails to detect root device correctly after arch/evbarm/evbarm/autoconf.c
 > changes on 20 Oct.
 
 hmmm, i thought that mlelstv's fdt_machdep.c revision 1.101 fixed that,
 but i guess there's a problem still.
 
 root detection is finding the real device, but in the above case it is
 choosing disklabel/mbr style naming, when this doesn't have a label,
 but should be choosing the wedge (dkN).
 
 i wonder if the problem is actually in init_main.c's
 rootconf_handle_wedges() where it tries to use booted_partition if
 booted_nblks == 0, and i see that it also wants booted_startblk set,
 but evbarm doesn't set these of these, only booted_device, where as
 here booted_device already is correctly set.
 
 does this reproduce easily in eg qemu?  also what things in /chosen
 are called either "netbsd,gpt-guid" or "netbsd,gpt-label" here?
 one or the other needs to exist for gpt disk boot.
 
 thanks.
 
 
 .mrg.