NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/57538: ptimer_tick and ptimer_intr abuse locks



>Number:         57538
>Category:       kern
>Synopsis:       ptimer_tick and ptimer_intr abuse locks
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jul 22 21:15:00 +0000 2023
>Originator:     Taylor R Campbell
>Release:        current
>Organization:
The NetBSD Timerdation
>Environment:
>Description:
- ptimer_tick takes a global lock on every hardclock tick, and it's the same one on every CPU, probably leading to unnecessary contention.

- ptimer_intr takes a global proc_lock from softint context, which is probably a bad idea (IPL_NONE) and probably also leads to unnecessary contention.

These should maybe have finer-grained locks or per-CPU storage that doesn't require locking.
>How-To-Repeat:
code inspection
>Fix:
Yes please!



Home | Main Index | Thread Index | Old Index