PR/54343 CVS commit: [netbsd-9] src/usr.sbin/makemandb

["Martin Husemann" <martin%netbsd.org@localhost>]

The following reply was made to PR bin/54343; it has been noted by GNATS.

From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/54343 CVS commit: [netbsd-9] src/usr.sbin/makemandb
Date: Fri, 3 Jun 2022 12:25:14 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Fri Jun  3 12:25:14 UTC 2022
 
 Modified Files:
 	src/usr.sbin/makemandb [netbsd-9]: apropos-utils.c apropos.1 apropos.c
 
 Log Message:
 Pull up following revision(s) (requested by gutteridge in ticket #1461):
 
 	usr.sbin/makemandb/apropos.1: revision 1.19
 	usr.sbin/makemandb/apropos.c: revision 1.25
 	usr.sbin/makemandb/apropos.c: revision 1.26
 	usr.sbin/makemandb/apropos.1: revision 1.20
 	usr.sbin/makemandb/apropos.1: revision 1.21
 	usr.sbin/makemandb/apropos.1: revision 1.22
 	usr.sbin/makemandb/apropos.1: revision 1.23
 	usr.sbin/makemandb/apropos-utils.c: revision 1.46
 	usr.sbin/makemandb/apropos-utils.c: revision 1.47
 	usr.sbin/makemandb/apropos-utils.c: revision 1.49
 
 PR/54343: Prevent NULL pointers in callback strings; use "*?*" for now to
 identify them.
 
 PR bin/54343:  We want the callback_args.machine to be NULL if it is not
 present in the DB.
 
 The previous commit fixed the problem of allowing apropos to not crash and
 produce output even if the database is missing values for certain mandatory
 fields, such as name, section etc. Normally we don't expect those values
 to be missing in the database but in case of parsing errors it can happen.
 
 However, the machine architecture is an optional field since not all man pages
 are hardware specific so that should be allowed to be set to NULL if not
 present in the database.
 
 apropos.c: fix pager functionality
 
 Issue reported by Rocky Hotas on NetBSD-Users, patch input from RVP on
 same, adjustments by me.
 
 apropos.1: document the PAGER environment variable
 
 apropos(1): use proper -width
 
 apropos(1): use proper -width for the list of options too
 
 apropos(1): Tweak the description of -1, ... -9, and -s
 
 -s is not for compatibility only, because section names can be
 anything.  E.g. we have 3lua and 9lua in base.  We have rudiments of
 3f (for FORTRAN libs).  Some packages in pkgsrc also use suffixed 1
 and 3 sections.
 
 apropos(1): Use the official spelling for "SQLite".
 While here, use .Bx to refer to 3BSD.
 
 apropos(1): improve error handling in edge cases
 Patch from RVP on NetBSD-Users, with an additional comment tweak by me.
 
 Summary from RVP:
 1. Ignore SIGPIPE so that we're not killed in the middle of some
    DB operation by a botched $PAGER:
 $ env PAGER=3D/non-existent apropos -p ...
 2. Return proper exit status in case of write errors:
 $ apropos ... >/dev/full || echo fail
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.45 -r1.45.2.1 src/usr.sbin/makemandb/apropos-utils.c
 cvs rdiff -u -r1.18 -r1.18.18.1 src/usr.sbin/makemandb/apropos.1
 cvs rdiff -u -r1.24 -r1.24.6.1 src/usr.sbin/makemandb/apropos.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.