Re: port-i386/56860: viadrmums module fails to load after drm update

[Andrius V <vezhlys%gmail.com@localhost>]

The following reply was made to PR port-i386/56860; it has been noted by GNATS.

From: Andrius V <vezhlys%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: port-i386-maintainer%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: port-i386/56860: viadrmums module fails to load after drm update
Date: Fri, 3 Jun 2022 12:31:55 +0300

 Hi,
 
 Currently my setup has drmkms as a built-in driver (since kernel
 includes other drm drivers), the patch doesn't seem to have any effect
 to viadrmums module. For testing purposes I built a kernel without any
 drm drivers, however separate drmkms module is obsolete and not
 included in the list of modules. If it is supposed to load with drm
 module, it also fails to load:
 kobj_checksyms, 1026: [drm]: linker error: global symbol `drm_ioctl' redefined
 WARNING: module error: unable to load `drm' pushed by boot loader, error 8
 
 
 On Fri, Jun 3, 2022 at 1:20 AM Paul Goyette <paul%whooppee.com@localhost> wrote:
 >
 > The following reply was made to PR port-i386/56860; it has been noted by GNATS.
 >
 > From: Paul Goyette <paul%whooppee.com@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: vezhlys%gmail.com@localhost
 > Subject: Re: port-i386/56860: viadrmums module fails to load after drm update
 > Date: Thu, 2 Jun 2022 15:16:22 -0700 (PDT)
 >
 >  port-i386-maintainer%netbsd.org@localhost,
 >  gnats-admin%netbsd.org@localhost,
 >  netbsd-bugs%netbsd.org@localhost
 >  Try the following patch.  This Makefile sets drm_bufs.c's COPTS but
 >  never includes the source file, which is where the missing symbols
 >  are defined!
 >
 >  XXX Not sure if this file belongs in the "NetBSD additions" section
 >  XXX of at the end of the file in the "Upstream source files" section.
 >
 >  Index: modules/drmkms/Makefile
 >  ===================================================================
 >  RCS file: /cvsroot/src/sys/modules/drmkms/Makefile,v
 >  retrieving revision 1.15
 >  diff -u -p -r1.15 Makefile
 >  --- modules/drmkms/Makefile     19 Dec 2021 11:54:24 -0000      1.15
 >  +++ modules/drmkms/Makefile     2 Jun 2022 22:11:02 -0000
 >  @@ -19,6 +19,7 @@ SRCS+=        drm_gem_vm.c
 >    SRCS+= drm_hdcp.c
 >    SRCS+= drm_module.c
 >    SRCS+= drm_sysctl.c
 >  +SRCS+= drm_bufs.c
 >
 >    SRCS+=  drm_pci_busid.c
 >
 >  ===================================================================
 >
 >  +--------------------+--------------------------+----------------------+
 >  | Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:    |
 >  | (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost    |
 >  | Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost  |
 >  | & Network Engineer |                          | pgoyette99%gmail.com@localhost |
 >  +--------------------+--------------------------+----------------------+
 >