Re: lib/55220: Possible color problem in curses and/or py-curses

[Brett Lymn <blymn%internode.on.net@localhost>]

The following reply was made to PR lib/55220; it has been noted by GNATS.

From: Brett Lymn <blymn%internode.on.net@localhost>
To: Thomas Klausner <wiz%NetBSD.org@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: lib/55220: Possible color problem in curses and/or py-curses
Date: Tue, 12 Apr 2022 16:59:50 +0930

 On Mon, Dec 06, 2021 at 05:38:52PM +0100, Thomas Klausner wrote:
 > On Mon, Dec 06, 2021 at 07:40:58AM +1030, Brett Lymn wrote:
 > > 
 > > Yes, that is what I was talking about.  I am sure it works fine in ncurses I suspect because
 > > the ncurses chgat() won't update the colour if the pair number is 0.  I am sure our colour
 > > handling is correct because the output matches screenshots out on the internet, chgat is
 > > only called when the cursor moves.  I will have a look at the chgat code now the attributes
 > > are coming through.
 > 
 > Ok, thanks. Let me know if the python code needs more changes.
 > 
 
 Right - that was more complicated than I imagined.  I needed to totally
 rework the colour code because I realised that we should be using colour
 pair 0 for the default colour (this is what fileobj was expecting), our
 default colour pair was set to the last possible pair in the set and
 there was no real way to use it.
 
 I have committed the fixes for the default colour and now fileobj
 appears to behave correctly.  Can you please update your libcurses and
 check?
 
 -- 
 Brett Lymn
 --
 Sent from my NetBSD device.
 
 "We are were wolves",
 "You mean werewolves?",
 "No we were wolves, now we are something else entirely",
 "Oh"