misc/56790: t_socket test buid failure

[prlw1%cam.ac.uk@localhost]

>Number:         56790
>Category:       misc
>Synopsis:       t_socket test buid failure
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 12 09:25:00 +0000 2022
>Originator:     Patrick Welche
>Release:        NetBSD-9.99.96/amd64 of 12 Apr 2022
>Organization:
>Environment:
>Description:
Building tests fails for me with:

# pwd
/usr/src/tests

dependall ===> include/sys
#      link  sys/t_socket
/usr/src/obj.amd64/tooldir.NetBSD-9.99.96-amd64/bin/x86_64--netbsd-gcc    --sysroot=/ -Wl,--warn-shared-textrel -Wl,-z,relro   -pie  -shared-libgcc      -o t_socket  t_socket.o  -Wl,-rpath-link,/lib  -L=/lib     -lrumpnet_local -lrumpnet_net -lrumpnet  -lrumpvfs -lrump -lrumpvfs -lrumpvfs_nofifofs -lrumpuser -lrump -lpthread -latf-c
/usr/obj/.amd64/tooldir.NetBSD-9.99.96-amd64/bin/../lib/gcc/x86_64--netbsd/10.3.0/../../../../x86_64--netbsd/bin/ld: /usr/lib/librumpnet_net.so: undefined reference to `rumpns_pmf_device_register1'
collect2: error: ld returned 1 exit status

rumpdev/obj.amd64/librumpdev.so.0.map:                0x0000000000004019
        rumpns_pmf_device_register1

>How-To-Repeat:

>Fix:
Simply adding rumpdev works around the failure - but is this correct?

Index: Makefile
===================================================================
RCS file: /cvsroot/src/tests/include/sys/Makefile,v
retrieving revision 1.16
diff -u -r1.16 Makefile
--- Makefile    31 May 2020 16:36:07 -0000      1.16
+++ Makefile    12 Apr 2022 09:21:03 -0000
@@ -27,7 +27,7 @@
 .if (${MKRUMP} != "no") && !defined(BSD_MK_COMPAT_FILE)
 TESTS_C+= t_socket
 CPPFLAGS.t_socket.c+=  -D_KERNTYPES
-LDADD.t_socket+=       -lrumpnet_local -lrumpnet_net -lrumpnet
+LDADD.t_socket+=       -lrumpnet_local -lrumpnet_net -lrumpnet -lrumpdev
 LDADD.t_socket+=       ${LIBRUMPBASE}
 .endif