Re: kern/56487 (binary compat broken for COMPAT_NETBSD32)

[Jason Thorpe <thorpej%me.com@localhost>]

The following reply was made to PR kern/56487; it has been noted by GNATS.

From: Jason Thorpe <thorpej%me.com@localhost>
To: Martin Husemann <martin%duskware.de@localhost>
Cc: "gnats-bugs%netbsd.org@localhost" <gnats-bugs%NetBSD.org@localhost>
Subject: Re: kern/56487 (binary compat broken for COMPAT_NETBSD32)
Date: Fri, 5 Nov 2021 07:04:41 -0700

 > On Nov 5, 2021, at 7:02 AM, Jason Thorpe <thorpej%me.com@localhost> wrote:
 >=20
 > This is because syscalls.master for COMPAT_NETBSD32 is wrong for =
 sigreturn14:
 >=20
 >        {
 >                ns(struct compat_16_netbsd32___sigreturn14_args),
 >                .sy_call =3D (sy_call_t *)sys_nomodule
 >        },              /* 295 =3D compat_16_netbsd32___sigreturn14 */
 >=20
 > (Those functions do exist on aarch64 and amd64.). This was all masked =
 before because sigcontext wasn=E2=80=99t being used by libc.
 
 Ah, no, I=E2=80=99m wrong, but only slightly=E2=80=A6 it=E2=80=99s =
 intended that the =E2=80=9Ccompat_16=E2=80=9D module get loaded.  But =
 it=E2=80=99s likely that in the PK_32 case, we need to load a different =
 one, and possibly hook it differently?  What a mess.
 
 -- thorpej