Re: misc/56468: Boot countdown display glitch

[RVP <rvp%SDF.ORG@localhost>]

The following reply was made to PR misc/56468; it has been noted by GNATS.

From: RVP <rvp%SDF.ORG@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: misc/56468: Boot countdown display glitch
Date: Thu, 28 Oct 2021 21:17:49 +0000 (UTC)

 On Thu, 28 Oct 2021, Kimmo Suominen wrote:
 
 > I think your patch would have worked if the printf at the end of the
 > for-loop were also deleted. However, this would have placed the cursor
 > on top of the number instead of at the end of the line after
 > "seconds." I committed a change that adds a conditional printf in the
 > case that a key was pressed, so the current cursor placement is
 > preserved.
 >
 
 In that case, it would make the code simpler if you do what the landisk
 port does in its awaitkey() and print both text and backspace into the
 same buffer and do a single print:
 
 sys/arch/landisk/stand/boot/cons.c
 
 And, some of the other awaitkey()s moght need the same treatment :):
 
 /usr/src/sys/arch/i386/stand/efiboot/eficons.c
 /usr/src/sys/arch/i386/stand/lib/pcio.c
 /usr/src/sys/arch/landisk/stand/boot/cons.c
 /mnt/usr/src/sys/stand/efiboot/prompt.c
 
 -RVP