Re: install/56303: On a fresh installation, /tmp on sparc64 is not sticky

[RVP <rvp%SDF.ORG@localhost>]

The following reply was made to PR install/56303; it has been noted by GNATS.

From: RVP <rvp%SDF.ORG@localhost>
To: Andreas Gustafsson <gson%gson.org@localhost>
Cc: gnats-bugs%netbsd.org@localhost, martin%netbsd.org@localhost, roland.illig%gmx.de@localhost,
        Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>, vezhlys%gmail.com@localhost
Subject: Re: install/56303: On a fresh installation, /tmp on sparc64 is not
 sticky
Date: Tue, 17 Aug 2021 22:54:28 +0000 (UTC)

 On Fri, 13 Aug 2021, Andreas Gustafsson wrote:
 
 > You wrote:
 >> As I noted before, the current progress sometimes loses the status
 >> of the gzip command, so, I've modified, and simplified, progress.c
 >> slightly so that it returns a proper exit code every time.
 >>
 >> Please try this new version; then we can see what causes tar to
 >> abort mid-stream.
 >
 > I believe my minimal change of progress.c 1.24 was sufficient to fix
 > the problem of the present PR.  Your suggested changes hint at other
 > bugs in progress(1) that also ought to be fixed, but a complete
 > replacement of the entire source file is not the appropriate way to
 > fix them.  Please file a separate PR for each remaining progress(1)
 > bug, with a patch if possible, but more importantly, with a
 > description of the problem.
 >
 
 Sorry for the late reply, but I am a bit bogged down at the moment.
 
 Re: progress.c 1.24: This test which you modified is not needed:
 
  	if (deadpid == -1 && errno == EINTR)
  		continue;
 
 By ths point all read/writes have finished, and `outpipe[1]' has
 been closed. So you can stop the progress bar code right after the
 `while (1)' loop and no interrupts can occur. This is what my
 initial patch did. The subsequent patch is more of the same: dotting
 the Is and crossing the Ts--very straight-forward stuff, but I
 wanted to ensure that progress(1) exited with a proper error code
 everytime.
 
 Hope that helps. Feel free to use any or all of the changes I made.
 
 -RVP