NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/55884: viadrmums* at vga* does not add new line in dmesg

The missing new line is likely related to undefined device name in the driver. An old viadrm driver was taking it from drm pciids. However, this information would be just a duplicate to the vga driver itself which prints device information, thus just adding a new line seems to be relevant fix. This patch works for me:

diff --git a/sys/external/bsd/drm2/via/via_pci.c b/sys/external/bsd/drm2/via/via_pci.c

--- a/sys/external/bsd/drm2/via/via_pci.c
+++ b/sys/external/bsd/drm2/via/via_pci.c
@@ -116,6 +116,9 @@ viadrm_attach(device_t parent, device_t self, void *aux)
        KASSERT(cookiep != NULL);
+       aprint_naive("\n");
+       aprint_normal("\n");
        if (!pmf_device_register(self, NULL, NULL))
                aprint_error_dev(self, "couldn't establish power handler\n");

relevant dmesg part after the patch:
pci1 at ppb0 bus 1
pci1: i/o space, memory space enabled
vga0 at pci1 dev 0 function 0: VIA Technologies product 3118 (rev. 0x02)
wsdisplay0 at vga0 kbdmux 1: console (80x25, vt100 emulation)
wsmux1: connecting to wsdisplay0
viadrmums0 at vga0
kern info: [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
kern info: [drm] No driver support for vblank timestamp query.

On Sat, Dec 19, 2020 at 11:30 PM <> wrote:
>Number:         55884
>Category:       kern
>Synopsis:       viadrmums* at vga* does not add new line in dmesg
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 19 21:30:00 +0000 2020
>Originator:     Andrius V
>Release:        NetBSD 9.1
Booting with viadrmums module (built-in or dynamic) prints it in dmesg without adding a new line, thus combining supposedly new line together with it, for example:
viadrmums0 at vga0kern info: [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).


viadrmums0 at vga0pci_mem_find: void region

Seems like very minor bug but I didn't find myself where the new line should be added.

Andrius V
Boot with viadrmums enabled on supported VIA hardware.

Home | Main Index | Thread Index | Old Index