Re: kern/55884: viadrmums* at vga* does not add new line in dmesg

[Andrius V <vezhlys%gmail.com@localhost>]

The following reply was made to PR kern/55884; it has been noted by GNATS.

From: Andrius V <vezhlys%gmail.com@localhost>
To: kern-bug-people%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, gnats-bugs%netbsd.org@localhost, 
	gnats-admin%netbsd.org@localhost
Cc: 
Subject: Re: kern/55884: viadrmums* at vga* does not add new line in dmesg
Date: Thu, 11 Feb 2021 23:43:44 +0200

 --00000000000092f07b05bb166a01
 Content-Type: text/plain; charset="UTF-8"
 
 The missing new line is likely related to undefined device name in the
 driver. An old viadrm driver was taking it from drm pciids. However, this
 information would be just a duplicate to the vga driver itself which prints
 device information, thus just adding a new line seems to be relevant fix.
 This patch works for me:
 
 diff --git a/sys/external/bsd/drm2/via/via_pci.c
 b/sys/external/bsd/drm2/via/via_pci.c
 
 --- a/sys/external/bsd/drm2/via/via_pci.c
 +++ b/sys/external/bsd/drm2/via/via_pci.c
 @@ -116,6 +116,9 @@ viadrm_attach(device_t parent, device_t self, void *aux)
 
         KASSERT(cookiep != NULL);
 
 +       aprint_naive("\n");
 +       aprint_normal("\n");
 +
         if (!pmf_device_register(self, NULL, NULL))
                 aprint_error_dev(self, "couldn't establish power
 handler\n");
 
 relevant dmesg part after the patch:
 ...
 pci1 at ppb0 bus 1
 pci1: i/o space, memory space enabled
 vga0 at pci1 dev 0 function 0: VIA Technologies product 3118 (rev. 0x02)
 wsdisplay0 at vga0 kbdmux 1: console (80x25, vt100 emulation)
 wsmux1: connecting to wsdisplay0
 viadrmums0 at vga0
 kern info: [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
 kern info: [drm] No driver support for vblank timestamp query.
 ...
 
 On Sat, Dec 19, 2020 at 11:30 PM <vezhlys%gmail.com@localhost> wrote:
 
 > >Number:         55884
 > >Category:       kern
 > >Synopsis:       viadrmums* at vga* does not add new line in dmesg
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    kern-bug-people
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Sat Dec 19 21:30:00 +0000 2020
 > >Originator:     Andrius V
 > >Release:        NetBSD 9.1
 > >Organization:
 > >Environment:
 > >Description:
 > Booting with viadrmums module (built-in or dynamic) prints it in dmesg
 > without adding a new line, thus combining supposedly new line together with
 > it, for example:
 > viadrmums0 at vga0kern info: [drm] Supports vblank timestamp caching Rev 2
 > (21.10.2013).
 >
 > or
 >
 > viadrmums0 at vga0pci_mem_find: void region
 >
 > Seems like very minor bug but I didn't find myself where the new line
 > should be added.
 >
 > Regards,
 > Andrius V
 > >How-To-Repeat:
 > Boot with viadrmums enabled on supported VIA hardware.
 > >Fix:
 >
 >
 
 --00000000000092f07b05bb166a01
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable
 
 <div dir=3D"ltr"><div>The missing new line is likely related to undefined d=
 evice name in the driver. An old viadrm driver was taking it from drm pciid=
 s. However, this information would be just a duplicate to the vga driver it=
 self which prints device information, thus just adding a new line seems to =
 be relevant fix. This patch works for me:</div><div><br></div>diff --git a/=
 sys/external/bsd/drm2/via/via_pci.c b/sys/external/bsd/drm2/via/via_pci.c<b=
 r><br>--- a/sys/external/bsd/drm2/via/via_pci.c<br>+++ b/sys/external/bsd/d=
 rm2/via/via_pci.c<br>@@ -116,6 +116,9 @@ viadrm_attach(device_t parent, dev=
 ice_t self, void *aux)<br>=C2=A0<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 KASSERT(coo=
 kiep !=3D NULL);<br>=C2=A0<br>+ =C2=A0 =C2=A0 =C2=A0 aprint_naive(&quot;\n&=
 quot;);<br>+ =C2=A0 =C2=A0 =C2=A0 aprint_normal(&quot;\n&quot;);<br>+<br>=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (!pmf_device_register(self, NULL, NULL))<br>=
 <div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 aprint_error_d=
 ev(self, &quot;couldn&#39;t establish power handler\n&quot;);</div><div><br=
 ></div><div>relevant dmesg part after the patch:</div><div>...<br></div><di=
 v>pci1 at ppb0 bus 1<br>pci1: i/o space, memory space enabled<br>vga0 at pc=
 i1 dev 0 function 0: VIA Technologies product 3118 (rev. 0x02)<br>wsdisplay=
 0 at vga0 kbdmux 1: console (80x25, vt100 emulation)<br>wsmux1: connecting =
 to wsdisplay0<br>viadrmums0 at vga0<br>kern info: [drm] Supports vblank tim=
 estamp caching Rev 2 (21.10.2013).<br>kern info: [drm] No driver support fo=
 r vblank timestamp query.</div><div>...<br></div></div><br><div class=3D"gm=
 ail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Dec 19, 2020 at 11=
 :30 PM &lt;<a href=3D"mailto:vezhlys%gmail.com@localhost";>vezhlys%gmail.com@localhost</a>&gt; w=
 rote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0p=
 x 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">&gt;Number=
 :=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A055884<br>
 &gt;Category:=C2=A0 =C2=A0 =C2=A0 =C2=A0kern<br>
 &gt;Synopsis:=C2=A0 =C2=A0 =C2=A0 =C2=A0viadrmums* at vga* does not add new=
  line in dmesg<br>
 &gt;Confidential:=C2=A0 =C2=A0no<br>
 &gt;Severity:=C2=A0 =C2=A0 =C2=A0 =C2=A0non-critical<br>
 &gt;Priority:=C2=A0 =C2=A0 =C2=A0 =C2=A0low<br>
 &gt;Responsible:=C2=A0 =C2=A0 kern-bug-people<br>
 &gt;State:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 open<br>
 &gt;Class:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 sw-bug<br>
 &gt;Submitter-Id:=C2=A0 =C2=A0net<br>
 &gt;Arrival-Date:=C2=A0 =C2=A0Sat Dec 19 21:30:00 +0000 2020<br>
 &gt;Originator:=C2=A0 =C2=A0 =C2=A0Andrius V<br>
 &gt;Release:=C2=A0 =C2=A0 =C2=A0 =C2=A0 NetBSD 9.1<br>
 &gt;Organization:<br>
 &gt;Environment:<br>
 &gt;Description:<br>
 Booting with viadrmums module (built-in or dynamic) prints it in dmesg with=
 out adding a new line, thus combining supposedly new line together with it,=
  for example:<br>
 viadrmums0 at vga0kern info: [drm] Supports vblank timestamp caching Rev 2 =
 (21.10.2013).<br>
 <br>
 or<br>
 <br>
 viadrmums0 at vga0pci_mem_find: void region<br>
 <br>
 Seems like very minor bug but I didn&#39;t find myself where the new line s=
 hould be added.<br>
 <br>
 Regards,<br>
 Andrius V<br>
 &gt;How-To-Repeat:<br>
 Boot with viadrmums enabled on supported VIA hardware.<br>
 &gt;Fix:<br>
 <br>
 </blockquote></div>
 
 --00000000000092f07b05bb166a01--