NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

misc/55824: missing \n in tunefs(8)



>Number:         55824
>Category:       misc
>Synopsis:       tunefs(8) is missing a \n when using '-p'
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 26 01:50:00 +0000 2020
>Originator:     Jan Schaumann
>Release:        NetBSD 9.99.76
>Organization:
	
>Environment:
	
	
Architecture: x86_64
Machine: amd64
>Description:

	When enabling POSIX ACLs via tunefs(8), the output is missing a trailing
	'\n':

	# tunefs -p enable /dev/wd1a
	tunefs: tuning /dev/rwd1a
	POSIX1e ACLs set#


>How-To-Repeat:
	# tunefs -p enable /dev/wd1a
>Fix:

Index: tunefs.c
===================================================================
RCS file: /cvsroot/src/sbin/tunefs/tunefs.c,v
retrieving revision 1.53
diff -u -r1.53 tunefs.c
--- tunefs.c	8 Aug 2020 11:44:55 -0000	1.53
+++ tunefs.c	26 Nov 2020 01:44:48 -0000
@@ -391,7 +391,7 @@
 				    "exclusive", name);
 			} else {
 				sblock.fs_flags |= FS_POSIX1EACLS;
-				printf("%s set", name);
+				printf("%s set\n", name);
 			}
 		} else if (strcmp(pvalue, "disable") == 0) {
 			if ((~sblock.fs_flags & FS_POSIX1EACLS) ==
@@ -400,7 +400,7 @@
 				    name);
 			} else {
 				sblock.fs_flags &= ~FS_POSIX1EACLS;
-				printf("%s cleared", name);
+				printf("%s cleared\n", name);
 			}
 		}
 	}

>Unformatted:
 	
 	


Home | Main Index | Thread Index | Old Index