NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/55243: panic at usb_transfer_complete() on raspberry pi 4



The following reply was made to PR kern/55243; it has been noted by GNATS.

From: Kouichi Hashikawa <hashikaw%mail.ru@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/55243: panic at usb_transfer_complete() on raspberry pi 4
Date: Fri, 15 May 2020 06:48:42 +0900

 --Apple-Mail-99698F4D-D406-421F-A1F2-01B193C1FDE1
 Content-Type: text/plain;
 	charset=utf-8
 Content-Transfer-Encoding: quoted-printable
 
 I think this is usb lan=E2=80=99s problem.
 I applied following patch, I don=E2=80=99t encounter problem.
 But, I don=E2=80=99t know this patch is correct...
 =20
 --------
 --- src/sys/external/bsd/dwc2/dwc2.c-1.73       2020-04-06 05:59:38.00000000=
 0 +0900
 +++ src/sys/external/bsd/dwc2/dwc2.c    2020-05-15 06:35:54.199752917 +0900
 @@ -335,6 +335,11 @@
          */
         mutex_spin_enter(&hsotg->lock);
         TAILQ_FOREACH_SAFE(dxfer, &sc->sc_complete, xnext, next) {
 +
 +               if (!dxfer->xfer.ux_pipe->up_repeat &&
 +                   &dxfer->xfer !=3D SIMPLEQ_FIRST(&dxfer->xfer.ux_pipe->up=
 _queue))
 +                       continue;
 +
                 if (!usbd_xfer_trycomplete(&dxfer->xfer))
                         /*
                          * The hard interrput handler decided to
 
 --------
 
 --=20
 Kouichi Hashikawa <hashikaw%mail.ru@localhost>
 
 
 --Apple-Mail-99698F4D-D406-421F-A1F2-01B193C1FDE1
 Content-Type: text/html;
 	charset=utf-8
 Content-Transfer-Encoding: quoted-printable
 
 <html><head><meta http-equiv=3D"content-type" content=3D"text/html; charset=3D=
 utf-8"></head><body dir=3D"auto"><div style=3D"-webkit-text-size-adjust: aut=
 o;">I think this is usb lan=E2=80=99s problem.</div><div style=3D"-webkit-te=
 xt-size-adjust: auto;">I applied following patch, I don=E2=80=99t encounter p=
 roblem.</div><div style=3D"-webkit-text-size-adjust: auto;">But, I don=E2=80=
 =99t know this patch is correct...</div><div style=3D"-webkit-text-size-adju=
 st: auto;">&nbsp;</div><div style=3D"-webkit-text-size-adjust: auto;">------=
 --</div><div style=3D"-webkit-text-size-adjust: auto;">--- src/sys/external/=
 bsd/dwc2/dwc2.c-1.73&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 2020-04-06 05:59:38=
 .000000000 +0900</div><div style=3D"-webkit-text-size-adjust: auto;">+++ src=
 /sys/external/bsd/dwc2/dwc2.c&nbsp;&nbsp;&nbsp;&nbsp;<a href=3D"tel:2020-05-=
 15" dir=3D"ltr" x-apple-data-detectors=3D"true" x-apple-data-detectors-type=3D=
 "telephone" x-apple-data-detectors-result=3D"1" style=3D"color: currentcolor=
 ;">2020-05-15</a>&nbsp;06:35:54.199752917 +0900<br>@@ -335,6 +335,11 @@<br>&=
 nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; */<br>&nbsp;&nbsp;&nbsp;&nbs=
 p;&nbsp;&nbsp;&nbsp; mutex_spin_enter(&amp;hsotg-&gt;lock);<br>&nbsp;&nbsp;&=
 nbsp;&nbsp;&nbsp;&nbsp;&nbsp; TAILQ_FOREACH_SAFE(dxfer, &amp;sc-&gt;sc_compl=
 ete, xnext, next) {<br>+<br>+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp=
 ;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (!dxfer-&gt;xfer.ux_pipe-&gt;up_rep=
 eat &amp;&amp;<br>+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
 sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &amp;dxfer-&gt;xfer !=3D=
  SIMPLEQ_FIRST(&amp;dxfer-&gt;xfer.ux_pipe-&gt;up_queue))<br>+&nbsp;&nbsp;&n=
 bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; continue;<br>+<br>&nbsp;&nbsp;&nb=
 sp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; i=
 f (!usbd_xfer_trycomplete(&amp;dxfer-&gt;xfer))<br>&nbsp;&nbsp;&nbsp;&nbsp;&=
 nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp=
 ;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /*<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
 bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; * The hard interrput handler decided to=
 </div><div style=3D"-webkit-text-size-adjust: auto;"><br>--------</div><br><=
 div dir=3D"ltr"><span style=3D"background-color: rgba(255, 255, 255, 0);">--=
 &nbsp;</span><div><span style=3D"background-color: rgba(255, 255, 255, 0);">=
 Kouichi Hashikawa &lt;hashikaw%mail.ru@localhost&gt;</span></div></div><div dir=3D"ltr=
 "><br></div></body></html>=
 
 --Apple-Mail-99698F4D-D406-421F-A1F2-01B193C1FDE1--
 



Home | Main Index | Thread Index | Old Index