Re: bin/54741: postinstall(8) fix no longer update /etc/rc.subr etc.

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR bin/54741; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: christos%zoulas.com@localhost
Cc: gnats-bugs%netbsd.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: bin/54741: postinstall(8) fix no longer update /etc/rc.subr etc.
Date: Sun, 22 Dec 2019 11:07:41 +0900

 >> Synopsis:       postinstall(8) fix no longer update /etc/rc.subr etc.
 
 > > I am worried that SRC_DIR does not work if not $SOURCEMODE,
 > 
 > I guess !$SOURCEMODE means $TGZMODE.
 > In that case SRC_DIR for the etc set is already handled,
 > at least it should work in select_obsolete_files():
 
 The above concern is for PR/54730, obsolete /etc/rc.d files.
 
 Is it okay to commit "rc* files in /etc/" part (for this PR) first?
 
 i.e. there is no info in src/distrib or /etc/mtree to check
 "which rc files can be overwritten unconditionally on upgrade"
 so postinstall(8) should have the list.
 
 Index: postinstall.in
 ===================================================================
 RCS file: /cvsroot/src/usr.sbin/postinstall/postinstall.in,v
 retrieving revision 1.5.2.2
 diff -u -p -d -r1.5.2.2 postinstall.in
 --- postinstall.in	10 Nov 2019 12:58:30 -0000	1.5.2.2
 +++ postinstall.in	22 Dec 2019 01:20:41 -0000
 @@ -1415,6 +1415,12 @@ do_pwd_mkdb()
  #	rc
  #
  
 +rc_644_files="
 +rc
 +rc.subr
 +rc.shutdown
 +"
 +
  rc_obsolete_vars="
  amd amd_master
  btcontrol btcontrol_devices
 @@ -1494,8 +1511,8 @@ do_rc()
  	local rc_external_files="blacklist nsd unbound"
  
  	# rc* files in /etc/
 -	local rc_444_files="$(select_set_files /etc/rc \
 -	    "/etc/\(rc[^[:space:]/]*\)" ${etcsets})"
 +	#local rc_644_files="$(select_set_files /etc/rc \
 +	#    "/etc/\(rc[^[:space:]/]*\)" ${etcsets})"
  
  	# no-obsolete rc files in /etc/rc.d
  	local rc_555_files="$(select_set_files /etc/rc.d/ \
 
 ---
 Izumi Tsutsui