Re: bin/54741: postinstall(8) fix no longer update /etc/rc.subr etc.

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR bin/54741; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: christos%zoulas.com@localhost
Cc: gnats-bugs%netbsd.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: bin/54741: postinstall(8) fix no longer update /etc/rc.subr etc.
Date: Sun, 8 Dec 2019 06:51:21 +0900

 > I am worried that SRC_DIR does not work if not $SOURCEMODE,
 
 I guess !$SOURCEMODE means $TGZMODE.
 In that case SRC_DIR for the etc set is already handled,
 at least it should work in select_obsolete_files():
 
 http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.sbin/postinstall/Attic/postinstall?annotate=1.232
 ---
 1.67      apb      2396:        # If '-s' arg or args specified tgz files, extract them
 1.39      apb      2397:        # to a scratch directory.
 1.1       lukem    2398:        #
 1.67      apb      2399:        if $TGZMODE; then
 1.1       lukem    2400:                ETCTGZDIR="${SCRATCHDIR}/etc.tgz"
 1.67      apb      2401:                echo "Note: Creating temporary directory ${ETCTGZDIR}"
 1.1       lukem    2402:                if ! mkdir "${ETCTGZDIR}"; then
 1.51      pavel    2403:                        err 2 "Can't create ${ETCTGZDIR}"
 1.1       lukem    2404:                fi
 
  :
 
 1.2       lukem    2415:                SRC_DIR="${ETCTGZDIR}"
 1.39      apb      2416:        else
                    2417:                SRC_DIR="${SRC_ARG}"
 1.1       lukem    2418:        fi
 ---
 
 (not sure other existing cases, like
  ${SRC_DIR}/usr.sbin/pf/etc/defaults
  ${SRC_DIR}/external/bsd/foo
  etc.)
 
 ---
 Izumi Tsutsui