Re: kern/54470: Adapt FFS to work with HP-UX UFS1 variant

[Konrad Schroder <perseant%hhhh.org@localhost>]

The following reply was made to PR kern/54470; it has been noted by GNATS.

From: Konrad Schroder <perseant%hhhh.org@localhost>
To: gnats-bugs%netbsd.org@localhost, kern-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, perseant%netbsd.org@localhost
Cc: 
Subject: Re: kern/54470: Adapt FFS to work with HP-UX UFS1 variant
Date: Fri, 16 Aug 2019 16:23:06 -0700

 But, setting dirblksiz in the posted diff is wrong.  It should read:
 
 --- setup.c     5 Oct 2018 09:49:23 -0000       1.102
 +++ setup.c     16 Aug 2019 23:18:54 -0000
 [...]
 @@ -551,6 +565,8 @@
  Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  dirblksiz = APPLEUFS_DIRBLKSIZ;
  Â Â Â Â Â Â Â  else
  Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  dirblksiz = UFS_DIRBLKSIZ;
 +Â Â Â Â Â Â  if (sblock->fs_magic == HP_FS_MAGIC_LFN && dirblksiz < 
 sblock->fs_fsize)
 +Â Â Â Â Â Â Â Â Â Â Â Â Â Â  dirblksiz = sblock->fs_fsize;
 
  Â Â Â Â Â Â Â  if (debug)
 [...]
 
 ...or possibly just hard-code an HP_FS_DIRBLKSIZ the way we do for 
 APPLEUFS_DIRBLKSIZ.
 
 Take care,
 
 -Konrad
 
 On 8/16/2019 4:11 PM, Konrad Schroder wrote:
 > Can you be more specific?  It gives the right values for my HP-UX 
 > image, and for existing NetBSD file systems.
 >
 > Thanks,
 >
 > -Konrad
 >
 > On 8/15/2019 11:05 PM, Michael van Elst wrote:
 >> The following reply was made to PR kern/54470; it has been noted by 
 >> GNATS.
 >>
 >> From: mlelstv%serpens.de@localhost (Michael van Elst)
 >> To: gnats-bugs%netbsd.org@localhost
 >> Cc:
 >> Subject: Re: kern/54470: Adapt FFS to work with HP-UX UFS1 variant
 >> Date: Fri, 16 Aug 2019 06:01:33 -0000 (UTC)
 >>
 >> Â  perseant%netbsd.org@localhost writes:
 >> Â  Â  >+/*
 >> Â  >+ * Turn byte counts into disk block counts.
 >> Â  >+ * Performs the same function as btodb(), but without
 >> Â  >+ * depending on a priori knowledge of DEV_BSIZE.
 >> Â  >+ */
 >> Â  >+#define BTODB(fs, size) ((size) >> ((fs)->fs_fshift - 
 >> (fs)->fs_fsbtodb))
 >> Â  >+#define DBTOB(fs, bc)Â Â  ((bc) << ((fs)->fs_fshift - 
 >> (fs)->fs_fsbtodb))
 >> Â  Â  I fear that doesn't work out.
 >> Â  Â  --
 >> Â  --
 >> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  Michael van Elst
 >> Â  Internet: mlelstv%serpens.de@localhost
 >> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  "A potential Snark may lurk in 
 >> every tree."