Re: kern/54470: Adapt FFS to work with HP-UX UFS1 variant

[Konrad Schroder <perseant%hhhh.org@localhost>]

But, setting dirblksiz in the posted diff is wrong.  It should read:

--- setup.c     5 Oct 2018 09:49:23 -0000       1.102
+++ setup.c     16 Aug 2019 23:18:54 -0000
[...]
@@ -551,6 +565,8 @@
                dirblksiz = APPLEUFS_DIRBLKSIZ;
        else
                dirblksiz = UFS_DIRBLKSIZ;
+       if (sblock->fs_magic == HP_FS_MAGIC_LFN && dirblksiz < 
sblock->fs_fsize)
+               dirblksiz = sblock->fs_fsize;

        if (debug)
[...]

...or possibly just hard-code an HP_FS_DIRBLKSIZ the way we do for 
APPLEUFS_DIRBLKSIZ.

Take care,

-Konrad

On 8/16/2019 4:11 PM, Konrad Schroder wrote:
> Can you be more specific?  It gives the right values for my HP-UX 
> image, and for existing NetBSD file systems.
>
> Thanks,
>
> -Konrad
>
> On 8/15/2019 11:05 PM, Michael van Elst wrote:
> > The following reply was made to PR kern/54470; it has been noted by 
> > GNATS.
> >
> > From: mlelstv%serpens.de@localhost (Michael van Elst)
> > To: gnats-bugs%netbsd.org@localhost
> > Cc:
> > Subject: Re: kern/54470: Adapt FFS to work with HP-UX UFS1 variant
> > Date: Fri, 16 Aug 2019 06:01:33 -0000 (UTC)
> >
> >   perseant%netbsd.org@localhost writes:
> >     >+/*
> >   >+ * Turn byte counts into disk block counts.
> >   >+ * Performs the same function as btodb(), but without
> >   >+ * depending on a priori knowledge of DEV_BSIZE.
> >   >+ */
> >   >+#define BTODB(fs, size) ((size) >> ((fs)->fs_fshift - 
> > (fs)->fs_fsbtodb))
> >   >+#define DBTOB(fs, bc)   ((bc) << ((fs)->fs_fshift - 
> > (fs)->fs_fsbtodb))
> >     I fear that doesn't work out.
> >     --
> >   --
> >                                   Michael van Elst
> >   Internet: mlelstv%serpens.de@localhost
> >                                   "A potential Snark may lurk in 
> > every tree."