re: port-evbarm/54308 - critical high priority sw-bug

[matthew green <mrg%eterna.com.au@localhost>]

The following reply was made to PR port-evbarm/54308; it has been noted by GNATS.

From: matthew green <mrg%eterna.com.au@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: port-evbarm-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
    netbsd-bugs%netbsd.org@localhost, mac%culver.net@localhost
Subject: re: port-evbarm/54308 - critical high priority sw-bug
Date: Fri, 09 Aug 2019 13:16:13 +1000

 hi Mike,
 
 thanks for checking.
 
 >  I verified that the patch was applied to my version of if_axen.c and it
 >  was.  There is still a bug:
 
 >  Configuring network interfaces: axen0[  73.2746617] panic: kernel
 >  diagnostic assertion "mutex_owned(&sc->axen_mii_lock)" failed: file
 >  "/c/usr/src/sys/dev/usb/if_axen.c", line 748
 
 yup.  this one comes because, in netbsd-9 and slightly older
 -current, i wrote this accidentally:
 
                 case SIOCSIFCAP:
                         mutex_enter(&sc->axen_lock);
                         axen_setcoe(sc);
                         mutex_exit(&sc->axen_lock);
 
 it should be taking axen_mii_lock.
 
 this is fixed in -current already, and i'll make sure it gets
 fixed in -9 too.
 
 thanks!
 
 
 .mrg.