NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: toolchain/54411: std::locale broken



The following reply was made to PR toolchain/54411; it has been noted by GNATS.

From: Christos Zoulas <christos%zoulas.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: toolchain-manager%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost,
 Thomas Klausner <wiz%NetBSD.org@localhost>
Subject: Re: toolchain/54411: std::locale broken
Date: Sun, 28 Jul 2019 20:46:10 +0300

 Ok, I put a new diff, and I committed all the dragonfly changes so they =
 are not part of that diff anymore and you need to cvs update.
 
 christos
 
 > On Jul 28, 2019, at 6:00 PM, Thomas Klausner <wiz%NetBSD.org@localhost> wrote:
 >=20
 > The following reply was made to PR toolchain/54411; it has been noted =
 by GNATS.
 >=20
 > From: Thomas Klausner <wiz%NetBSD.org@localhost>
 > To: Christos Zoulas <christos%zoulas.com@localhost>
 > Cc: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
 > Subject: Re: toolchain/54411: std::locale broken
 > Date: Sun, 28 Jul 2019 16:58:39 +0200
 >=20
 > Does this include a fix for:
 >=20
 > =
 /usr/src/external/gpl3/gcc/dist/libstdc++-v3/config/locale/dragonfly/codec=
 vt_members.cc:53:36: error: 'uselocale' was not declared in this scope
 >      __c_locale __old =3D =
 (__c_locale)uselocale((locale_t)_M_c_locale_codecvt);
 >                                     ^~~~~~~~~
 > =
 /usr/src/external/gpl3/gcc/dist/libstdc++-v3/config/locale/dragonfly/codec=
 vt_members.cc:53:36: note: suggested alternative: 'setlocale'
 >      __c_locale __old =3D =
 (__c_locale)uselocale((locale_t)_M_c_locale_codecvt);
 >                                     ^~~~~~~~~
 >                                     setlocale
 >=20
 >=20
 > ?
 >=20
 > (Just saw this, hadn't reported it yet.)
 >  Thomas
 >=20
 >=20
 > On Sun, Jul 28, 2019 at 05:54:43PM +0300, Christos Zoulas wrote:
 >> I updated the http://www.netbsd.org/~christos/g++locale.diff =
 <http://www.netbsd.org/~christos/g++locale.diff> file to include all the =
 diffs.
 >>=20
 >> christos
 >>=20
 >>> On Jul 28, 2019, at 11:00 AM, Christos Zoulas <christos%zoulas.com@localhost> =
 wrote:
 >>>=20
 >>> The following reply was made to PR toolchain/54411; it has been =
 noted by GNATS.
 >>>=20
 >>> From: Christos Zoulas <christos%zoulas.com@localhost>
 >>> To: gnats-bugs%netbsd.org@localhost
 >>> Cc: toolchain-manager%netbsd.org@localhost,
 >>> gnats-admin%netbsd.org@localhost,
 >>> netbsd-bugs%netbsd.org@localhost,
 >>> Thomas Klausner <wiz%NetBSD.org@localhost>
 >>> Subject: Re: toolchain/54411: std::locale broken
 >>> Date: Sun, 28 Jul 2019 10:55:14 +0300
 >>>=20
 >>> --Apple-Mail=3D_558F2DC0-A9C0-4379-94AB-98B5D2813F8F
 >>> Content-Transfer-Encoding: quoted-printable
 >>> Content-Type: text/plain;
 >>> 	charset=3Dus-ascii
 >>>=20
 >>> Add this diff: https://www.netbsd.org/~christos/c_locale.h.diff =3D
 >>> <https://www.netbsd.org/~christos/c_locale.h.diff>
 >>>=20
 >>> christos
 >>>=20
 >>>> On Jul 28, 2019, at 10:45 AM, Christos Zoulas <christos%zoulas.com@localhost> =
 =3D
 >>> wrote:
 >>>> =3D20
 >>>> The following reply was made to PR toolchain/54411; it has been =
 noted =3D
 >>> by GNATS.
 >>>> =3D20
 >>>> From: Christos Zoulas <christos%zoulas.com@localhost>
 >>>> To: gnats-bugs%netbsd.org@localhost
 >>>> Cc: toolchain-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 >>>> netbsd-bugs%netbsd.org@localhost, Thomas Klausner <wiz%netbsd.org@localhost>
 >>>> Subject: Re: toolchain/54411: std::locale broken
 >>>> Date: Sun, 28 Jul 2019 10:41:25 +0300
 >>>> =3D20
 >>>> You just need to rebuild libstdc++
 >>>> =3D20
 >>>> christos
 >>>> =3D20
 >>>>> On Jul 27, 2019, at 11:50 PM, Thomas Klausner <wiz%netbsd.org@localhost> =
 wrote:
 >>>>> =3D3D20
 >>>>> The following reply was made to PR toolchain/54411; it has been =
 noted =3D
 >>> by G=3D3D
 >>>> NATS.
 >>>>> =3D3D20
 >>>>> From: Thomas Klausner <wiz%NetBSD.org@localhost>
 >>>>> To: Christos Zoulas <christos%zoulas.com@localhost>
 >>>>> Cc: gnats-bugs%netbsd.org@localhost
 >>>>> Subject: Re: toolchain/54411: std::locale broken
 >>>>> Date: Sat, 27 Jul 2019 22:49:29 +0200
 >>>>> =3D3D20
 >>>>>> On Sat, Jul 27, 2019 at 08:35:01PM +0000, Christos Zoulas wrote:
 >>>>>> See https://www.netbsd.org/~christos/g++locale.diff
 >>>>> =3D3D20
 >>>>> I'll try that. IIUC, I just need to reinstall the base system =
 after
 >>>>> this change, since this will change the libstdc++ so the test =
 program
 >>>>> (and gnucash) should start working after this change without a
 >>>>> rebuild, right?
 >>>>> =3D3D20
 >>>>> Thank you!
 >>>>> Thomas
 >>>>> =3D3D20
 >>>> =3D20
 >>>=20
 >>>=20
 >>> --Apple-Mail=3D_558F2DC0-A9C0-4379-94AB-98B5D2813F8F
 >>> Content-Transfer-Encoding: quoted-printable
 >>> Content-Type: text/html;
 >>> 	charset=3Dus-ascii
 >>>=20
 >>> <html><head><meta http-equiv=3D3D"Content-Type" =
 content=3D3D"text/html; =3D
 >>> charset=3D3Dus-ascii"></head><body DEFANGED_style=3D3D"word-wrap: =
 break-word; =3D
 >>> -webkit-nbsp-mode: space; line-break: after-white-space;" =
 class=3D'3D""'>Add =3D
 >>> this diff: <a =
 href=3D3D"https://www.netbsd.org/~christos/c_locale.h.diff"; =3D
 >>> =
 class=3D3D"">https://www.netbsd.org/~christos/c_locale.h.diff</a><p><DEFAN=
 GED_div =3D
 >>> class=3D3D""><br class=3D3D""></p><DEFANGED_div><p><DEFANGED_div =
 class=3D3D"">christos<br =3D
 >>> class=3D3D""><p><DEFANGED_div><br class=3D3D""><blockquote =
 type=3D3D"cite" class=3D3D""><p><DEFANGED_div =3D
 >>> class=3D3D"">On Jul 28, 2019, at 10:45 AM, Christos Zoulas &lt;<a =3D
 >>> href=3D3D"mailto:christos%zoulas.com@localhost"; =
 class=3D3D"">christos%zoulas.com@localhost</a>&gt;=3D
 >>> wrote:</p><DEFANGED_div><br =
 class=3D3D"Apple-interchange-newline"><p><DEFANGED_div =
 class=3D3D""><p><DEFANGED_div =3D
 >>> class=3D3D"">The following reply was made to PR toolchain/54411; it =
 has =3D
 >>> been noted by GNATS.<br class=3D3D""><br class=3D3D"">From: Christos =
 Zoulas =3D
 >>> &lt;<a href=3D3D"mailto:christos%zoulas.com@localhost"; =3D
 >>> class=3D3D"">christos%zoulas.com@localhost</a>&gt;<br class=3D3D"">To: <a =3D
 >>> href=3D3D"mailto:gnats-bugs%netbsd.org@localhost"; =3D
 >>> class=3D3D"">gnats-bugs%netbsd.org@localhost</a><br class=3D3D"">Cc: <a =3D
 >>> href=3D3D"mailto:toolchain-manager%netbsd.org@localhost"; =3D
 >>> class=3D3D"">toolchain-manager%netbsd.org@localhost</a>, <a =3D
 >>> href=3D3D"mailto:gnats-admin%netbsd.org@localhost"; =3D
 >>> class=3D3D"">gnats-admin%netbsd.org@localhost</a>,<br class=3D3D""> <a =3D
 >>> href=3D3D"mailto:netbsd-bugs%netbsd.org@localhost"; =3D
 >>> class=3D3D"">netbsd-bugs%netbsd.org@localhost</a>, Thomas Klausner &lt;<a =3D
 >>> href=3D3D"mailto:wiz%netbsd.org@localhost"; =
 class=3D3D"">wiz%netbsd.org@localhost</a>&gt;<br =3D
 >>> class=3D3D"">Subject: Re: toolchain/54411: std::locale broken<br =3D
 >>> class=3D3D"">Date: Sun, 28 Jul 2019 10:41:25 +0300<br class=3D3D""><br=
  =3D
 >>> class=3D3D""> You just need to rebuild libstdc++<br class=3D3D""><br =
 =3D
 >>> class=3D3D""> christos<br class=3D3D""><br class=3D3D""><blockquote =
 =3D
 >>> type=3D3D"cite" class=3D3D"">On Jul 27, 2019, at 11:50 PM, Thomas =
 Klausner =3D
 >>> &lt;<a href=3D3D"mailto:wiz%netbsd.org@localhost"; =
 class=3D3D"">wiz%netbsd.org@localhost</a>&gt; =3D
 >>> wrote:<br class=3D3D"">=3D3D20<br class=3D3D"">The following reply =
 was made to =3D
 >>> PR toolchain/54411; it has been noted by G=3D3D<br =
 class=3D3D""></blockquote> =3D
 >>> NATS.<br class=3D3D""><blockquote type=3D3D"cite" =
 class=3D3D"">=3D3D20<br =3D
 >>> class=3D3D"">From: Thomas Klausner &lt;<a =
 href=3D3D"mailto:wiz%NetBSD.org@localhost"; =3D
 >>> class=3D3D"">wiz%NetBSD.org@localhost</a>&gt;<br class=3D3D"">To: Christos =
 Zoulas =3D
 >>> &lt;<a href=3D3D"mailto:christos%zoulas.com@localhost"; =3D
 >>> class=3D3D"">christos%zoulas.com@localhost</a>&gt;<br class=3D3D"">Cc: <a =3D
 >>> href=3D3D"mailto:gnats-bugs%netbsd.org@localhost"; =3D
 >>> class=3D3D"">gnats-bugs%netbsd.org@localhost</a><br class=3D3D"">Subject: Re: =
 =3D
 >>> toolchain/54411: std::locale broken<br class=3D3D"">Date: Sat, 27 =
 Jul 2019 =3D
 >>> 22:49:29 +0200<br class=3D3D"">=3D3D20<br class=3D3D""><blockquote =
 DEFANGED_type=3D'3D"cite"=3D'
 >>> class=3D'3D""'>On Sat, Jul 27, 2019 at 08:35:01PM +0000, Christos =
 Zoulas =3D
 >>> wrote:<br class=3D3D"">See <a =3D
 >>> href=3D3D"https://www.netbsd.org/~christos/g++locale.diff"; =3D
 >>> class=3D3D"">https://www.netbsd.org/~christos/g++locale.diff</a><br =
 =3D
 >>> class=3D3D""></blockquote>=3D3D20<br class=3D3D"">I'll try that. =
 IIUC, I just =3D
 >>> need to reinstall the base system after<br class=3D3D"">this change, =
 since =3D
 >>> this will change the libstdc++ so the test program<br =
 class=3D3D"">(and =3D
 >>> gnucash) should start working after this change without a<br =3D
 >>> class=3D3D"">rebuild, right?<br class=3D3D"">=3D3D20<br =
 class=3D3D"">Thank =3D
 >>> you!<br class=3D3D""> Thomas<br class=3D3D"">=3D3D20<br =3D
 >>> class=3D3D""></blockquote><br =
 class=3D3D""></p><DEFANGED_div></p><DEFANGED_div></blockquote></p><DEFANGE=
 D_div><br =3D
 >>> class=3D3D""></p><DEFANGED_div></body></html>=3D
 >>>=20
 >>> --Apple-Mail=3D_558F2DC0-A9C0-4379-94AB-98B5D2813F8F--
 >>>=20
 >>>=20
 >>>=20
 >>> --=20
 >>> This message has been 'sanitized'.  This means that potentially
 >>> dangerous content has been rewritten or removed.  The following
 >>> log describes which actions were taken.
 >>>=20
 >>> Sanitizer (start=3D"1564300807"):
 >>> SanitizeFile (filename=3D"unnamed.txt, filetype.html", =
 mimetype=3D"text/plain"):
 >>>   Match (names=3D"unnamed.txt, filetype.html", rule=3D"9"):
 >>>     Enforced policy: accept
 >>>=20
 >>> Rewrote HTML tag: >>_body style=3D3D"word-wrap: break-word; =3D =
 -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D3D""_<<
 >>>               as: >>_body DEFANGED_style=3D3D"word-wrap: break-word; =
 =3D -webkit-nbsp-mode: space; line-break: after-white-space;" =
 class=3D'3D""'_<<
 >>> Note: Styles and layers give attackers many tools to fool the
 >>> user and common browsers interpret Javascript code found
 >>> within style definitions.
 >>>=20
 >>> Rewrote HTML tag: >>_div =3D class=3D3D""_<<
 >>>               as: >>_p__DEFANGED_div =3D class=3D3D""_<<
 >>> Rewrote HTML tag: >>_/div_<<
 >>>               as: >>_/p__DEFANGED_div_<<
 >>> Rewrote HTML tag: >>_div class=3D3D""_<<
 >>>               as: >>_p__DEFANGED_div class=3D3D""_<<
 >>> Rewrote HTML tag: >>_div_<<
 >>>               as: >>_p__DEFANGED_div_<<
 >>> Rewrote HTML tag: >>_div =3D class=3D3D""_<<
 >>>               as: >>_p__DEFANGED_div =3D class=3D3D""_<<
 >>> Rewrote HTML tag: >>_/div_<<
 >>>               as: >>_/p__DEFANGED_div_<<
 >>> Rewrote HTML tag: >>_div class=3D3D""_<<
 >>>               as: >>_p__DEFANGED_div class=3D3D""_<<
 >>> Rewrote HTML tag: >>_div =3D class=3D3D""_<<
 >>>               as: >>_p__DEFANGED_div =3D class=3D3D""_<<
 >>> Rewrote HTML tag: >>_blockquote type=3D3D"cite"=3D class=3D3D""_<<
 >>>               as: >>_blockquote DEFANGED_type=3D'3D"cite"=3D' =
 class=3D'3D""'_<<
 >>> Rewrote HTML tag: >>_/div_<<
 >>>               as: >>_/p__DEFANGED_div_<<
 >>> Rewrote HTML tag: >>_/div_<<
 >>>               as: >>_/p__DEFANGED_div_<<
 >>> Rewrote HTML tag: >>_/div_<<
 >>>               as: >>_/p__DEFANGED_div_<<
 >>> Rewrote HTML tag: >>_/div_<<
 >>>               as: >>_/p__DEFANGED_div_<<
 >>> Total modifications so far: 14
 >>>=20
 >>>=20
 >>> Anomy 0.0.0 : Sanitizer.pm
 >>> $Id: Sanitizer.pm,v 1.94 2006/01/02 16:43:10 bre Exp $
 >>=20
 >=20
 



Home | Main Index | Thread Index | Old Index