NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: toolchain/54411: std::locale broken



Ok, I put a new diff, and I committed all the dragonfly changes so they are not part of that diff anymore and you need to cvs update.

christos

> On Jul 28, 2019, at 6:00 PM, Thomas Klausner <wiz%NetBSD.org@localhost> wrote:
> 
> The following reply was made to PR toolchain/54411; it has been noted by GNATS.
> 
> From: Thomas Klausner <wiz%NetBSD.org@localhost>
> To: Christos Zoulas <christos%zoulas.com@localhost>
> Cc: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
> Subject: Re: toolchain/54411: std::locale broken
> Date: Sun, 28 Jul 2019 16:58:39 +0200
> 
> Does this include a fix for:
> 
> /usr/src/external/gpl3/gcc/dist/libstdc++-v3/config/locale/dragonfly/codecvt_members.cc:53:36: error: 'uselocale' was not declared in this scope
>      __c_locale __old = (__c_locale)uselocale((locale_t)_M_c_locale_codecvt);
>                                     ^~~~~~~~~
> /usr/src/external/gpl3/gcc/dist/libstdc++-v3/config/locale/dragonfly/codecvt_members.cc:53:36: note: suggested alternative: 'setlocale'
>      __c_locale __old = (__c_locale)uselocale((locale_t)_M_c_locale_codecvt);
>                                     ^~~~~~~~~
>                                     setlocale
> 
> 
> ?
> 
> (Just saw this, hadn't reported it yet.)
>  Thomas
> 
> 
> On Sun, Jul 28, 2019 at 05:54:43PM +0300, Christos Zoulas wrote:
>> I updated the http://www.netbsd.org/~christos/g++locale.diff <http://www.netbsd.org/~christos/g++locale.diff> file to include all the diffs.
>> 
>> christos
>> 
>>> On Jul 28, 2019, at 11:00 AM, Christos Zoulas <christos%zoulas.com@localhost> wrote:
>>> 
>>> The following reply was made to PR toolchain/54411; it has been noted by GNATS.
>>> 
>>> From: Christos Zoulas <christos%zoulas.com@localhost>
>>> To: gnats-bugs%netbsd.org@localhost
>>> Cc: toolchain-manager%netbsd.org@localhost,
>>> gnats-admin%netbsd.org@localhost,
>>> netbsd-bugs%netbsd.org@localhost,
>>> Thomas Klausner <wiz%NetBSD.org@localhost>
>>> Subject: Re: toolchain/54411: std::locale broken
>>> Date: Sun, 28 Jul 2019 10:55:14 +0300
>>> 
>>> --Apple-Mail=_558F2DC0-A9C0-4379-94AB-98B5D2813F8F
>>> Content-Transfer-Encoding: quoted-printable
>>> Content-Type: text/plain;
>>> 	charset=us-ascii
>>> 
>>> Add this diff: https://www.netbsd.org/~christos/c_locale.h.diff =
>>> <https://www.netbsd.org/~christos/c_locale.h.diff>
>>> 
>>> christos
>>> 
>>>> On Jul 28, 2019, at 10:45 AM, Christos Zoulas <christos%zoulas.com@localhost> =
>>> wrote:
>>>> =20
>>>> The following reply was made to PR toolchain/54411; it has been noted =
>>> by GNATS.
>>>> =20
>>>> From: Christos Zoulas <christos%zoulas.com@localhost>
>>>> To: gnats-bugs%netbsd.org@localhost
>>>> Cc: toolchain-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
>>>> netbsd-bugs%netbsd.org@localhost, Thomas Klausner <wiz%netbsd.org@localhost>
>>>> Subject: Re: toolchain/54411: std::locale broken
>>>> Date: Sun, 28 Jul 2019 10:41:25 +0300
>>>> =20
>>>> You just need to rebuild libstdc++
>>>> =20
>>>> christos
>>>> =20
>>>>> On Jul 27, 2019, at 11:50 PM, Thomas Klausner <wiz%netbsd.org@localhost> wrote:
>>>>> =3D20
>>>>> The following reply was made to PR toolchain/54411; it has been noted =
>>> by G=3D
>>>> NATS.
>>>>> =3D20
>>>>> From: Thomas Klausner <wiz%NetBSD.org@localhost>
>>>>> To: Christos Zoulas <christos%zoulas.com@localhost>
>>>>> Cc: gnats-bugs%netbsd.org@localhost
>>>>> Subject: Re: toolchain/54411: std::locale broken
>>>>> Date: Sat, 27 Jul 2019 22:49:29 +0200
>>>>> =3D20
>>>>>> On Sat, Jul 27, 2019 at 08:35:01PM +0000, Christos Zoulas wrote:
>>>>>> See https://www.netbsd.org/~christos/g++locale.diff
>>>>> =3D20
>>>>> I'll try that. IIUC, I just need to reinstall the base system after
>>>>> this change, since this will change the libstdc++ so the test program
>>>>> (and gnucash) should start working after this change without a
>>>>> rebuild, right?
>>>>> =3D20
>>>>> Thank you!
>>>>> Thomas
>>>>> =3D20
>>>> =20
>>> 
>>> 
>>> --Apple-Mail=_558F2DC0-A9C0-4379-94AB-98B5D2813F8F
>>> Content-Transfer-Encoding: quoted-printable
>>> Content-Type: text/html;
>>> 	charset=us-ascii
>>> 
>>> <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; =
>>> charset=3Dus-ascii"></head><body DEFANGED_style=3D"word-wrap: break-word; =
>>> -webkit-nbsp-mode: space; line-break: after-white-space;" class='3D""'>Add =
>>> this diff: <a href=3D"https://www.netbsd.org/~christos/c_locale.h.diff"; =
>>> class=3D"">https://www.netbsd.org/~christos/c_locale.h.diff</a><p><DEFANGED_div =
>>> class=3D""><br class=3D""></p><DEFANGED_div><p><DEFANGED_div class=3D"">christos<br =
>>> class=3D""><p><DEFANGED_div><br class=3D""><blockquote type=3D"cite" class=3D""><p><DEFANGED_div =
>>> class=3D"">On Jul 28, 2019, at 10:45 AM, Christos Zoulas &lt;<a =
>>> href=3D"mailto:christos%zoulas.com@localhost"; class=3D"">christos%zoulas.com@localhost</a>&gt;=
>>> wrote:</p><DEFANGED_div><br class=3D"Apple-interchange-newline"><p><DEFANGED_div class=3D""><p><DEFANGED_div =
>>> class=3D"">The following reply was made to PR toolchain/54411; it has =
>>> been noted by GNATS.<br class=3D""><br class=3D"">From: Christos Zoulas =
>>> &lt;<a href=3D"mailto:christos%zoulas.com@localhost"; =
>>> class=3D"">christos%zoulas.com@localhost</a>&gt;<br class=3D"">To: <a =
>>> href=3D"mailto:gnats-bugs%netbsd.org@localhost"; =
>>> class=3D"">gnats-bugs%netbsd.org@localhost</a><br class=3D"">Cc: <a =
>>> href=3D"mailto:toolchain-manager%netbsd.org@localhost"; =
>>> class=3D"">toolchain-manager%netbsd.org@localhost</a>, <a =
>>> href=3D"mailto:gnats-admin%netbsd.org@localhost"; =
>>> class=3D"">gnats-admin%netbsd.org@localhost</a>,<br class=3D""> <a =
>>> href=3D"mailto:netbsd-bugs%netbsd.org@localhost"; =
>>> class=3D"">netbsd-bugs%netbsd.org@localhost</a>, Thomas Klausner &lt;<a =
>>> href=3D"mailto:wiz%netbsd.org@localhost"; class=3D"">wiz%netbsd.org@localhost</a>&gt;<br =
>>> class=3D"">Subject: Re: toolchain/54411: std::locale broken<br =
>>> class=3D"">Date: Sun, 28 Jul 2019 10:41:25 +0300<br class=3D""><br =
>>> class=3D""> You just need to rebuild libstdc++<br class=3D""><br =
>>> class=3D""> christos<br class=3D""><br class=3D""><blockquote =
>>> type=3D"cite" class=3D"">On Jul 27, 2019, at 11:50 PM, Thomas Klausner =
>>> &lt;<a href=3D"mailto:wiz%netbsd.org@localhost"; class=3D"">wiz%netbsd.org@localhost</a>&gt; =
>>> wrote:<br class=3D"">=3D20<br class=3D"">The following reply was made to =
>>> PR toolchain/54411; it has been noted by G=3D<br class=3D""></blockquote> =
>>> NATS.<br class=3D""><blockquote type=3D"cite" class=3D"">=3D20<br =
>>> class=3D"">From: Thomas Klausner &lt;<a href=3D"mailto:wiz%NetBSD.org@localhost"; =
>>> class=3D"">wiz%NetBSD.org@localhost</a>&gt;<br class=3D"">To: Christos Zoulas =
>>> &lt;<a href=3D"mailto:christos%zoulas.com@localhost"; =
>>> class=3D"">christos%zoulas.com@localhost</a>&gt;<br class=3D"">Cc: <a =
>>> href=3D"mailto:gnats-bugs%netbsd.org@localhost"; =
>>> class=3D"">gnats-bugs%netbsd.org@localhost</a><br class=3D"">Subject: Re: =
>>> toolchain/54411: std::locale broken<br class=3D"">Date: Sat, 27 Jul 2019 =
>>> 22:49:29 +0200<br class=3D"">=3D20<br class=3D""><blockquote DEFANGED_type='3D"cite"='
>>> class='3D""'>On Sat, Jul 27, 2019 at 08:35:01PM +0000, Christos Zoulas =
>>> wrote:<br class=3D"">See <a =
>>> href=3D"https://www.netbsd.org/~christos/g++locale.diff"; =
>>> class=3D"">https://www.netbsd.org/~christos/g++locale.diff</a><br =
>>> class=3D""></blockquote>=3D20<br class=3D"">I'll try that. IIUC, I just =
>>> need to reinstall the base system after<br class=3D"">this change, since =
>>> this will change the libstdc++ so the test program<br class=3D"">(and =
>>> gnucash) should start working after this change without a<br =
>>> class=3D"">rebuild, right?<br class=3D"">=3D20<br class=3D"">Thank =
>>> you!<br class=3D""> Thomas<br class=3D"">=3D20<br =
>>> class=3D""></blockquote><br class=3D""></p><DEFANGED_div></p><DEFANGED_div></blockquote></p><DEFANGED_div><br =
>>> class=3D""></p><DEFANGED_div></body></html>=
>>> 
>>> --Apple-Mail=_558F2DC0-A9C0-4379-94AB-98B5D2813F8F--
>>> 
>>> 
>>> 
>>> -- 
>>> This message has been 'sanitized'.  This means that potentially
>>> dangerous content has been rewritten or removed.  The following
>>> log describes which actions were taken.
>>> 
>>> Sanitizer (start="1564300807"):
>>> SanitizeFile (filename="unnamed.txt, filetype.html", mimetype="text/plain"):
>>>   Match (names="unnamed.txt, filetype.html", rule="9"):
>>>     Enforced policy: accept
>>> 
>>> Rewrote HTML tag: >>_body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""_<<
>>>               as: >>_body DEFANGED_style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class='3D""'_<<
>>> Note: Styles and layers give attackers many tools to fool the
>>> user and common browsers interpret Javascript code found
>>> within style definitions.
>>> 
>>> Rewrote HTML tag: >>_div = class=3D""_<<
>>>               as: >>_p__DEFANGED_div = class=3D""_<<
>>> Rewrote HTML tag: >>_/div_<<
>>>               as: >>_/p__DEFANGED_div_<<
>>> Rewrote HTML tag: >>_div class=3D""_<<
>>>               as: >>_p__DEFANGED_div class=3D""_<<
>>> Rewrote HTML tag: >>_div_<<
>>>               as: >>_p__DEFANGED_div_<<
>>> Rewrote HTML tag: >>_div = class=3D""_<<
>>>               as: >>_p__DEFANGED_div = class=3D""_<<
>>> Rewrote HTML tag: >>_/div_<<
>>>               as: >>_/p__DEFANGED_div_<<
>>> Rewrote HTML tag: >>_div class=3D""_<<
>>>               as: >>_p__DEFANGED_div class=3D""_<<
>>> Rewrote HTML tag: >>_div = class=3D""_<<
>>>               as: >>_p__DEFANGED_div = class=3D""_<<
>>> Rewrote HTML tag: >>_blockquote type=3D"cite"= class=3D""_<<
>>>               as: >>_blockquote DEFANGED_type='3D"cite"=' class='3D""'_<<
>>> Rewrote HTML tag: >>_/div_<<
>>>               as: >>_/p__DEFANGED_div_<<
>>> Rewrote HTML tag: >>_/div_<<
>>>               as: >>_/p__DEFANGED_div_<<
>>> Rewrote HTML tag: >>_/div_<<
>>>               as: >>_/p__DEFANGED_div_<<
>>> Rewrote HTML tag: >>_/div_<<
>>>               as: >>_/p__DEFANGED_div_<<
>>> Total modifications so far: 14
>>> 
>>> 
>>> Anomy 0.0.0 : Sanitizer.pm
>>> $Id: Sanitizer.pm,v 1.94 2006/01/02 16:43:10 bre Exp $
>> 
> 



Home | Main Index | Thread Index | Old Index