Re: bin/52737 (bmake crash for invalid usage of .PATH)

[Christos Zoulas <christos%zoulas.com@localhost>]

The following reply was made to PR bin/52737; it has been noted by GNATS.

From: Christos Zoulas <christos%zoulas.com@localhost>
To: "Simon J. Gerraty" <sjg%juniper.net@localhost>
Cc: gnats-bugs%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost,
 n54%gmx.com@localhost,
 "bsiegert%netbsd.org@localhost" <bsiegert%netbsd.org@localhost>
Subject: Re: bin/52737 (bmake crash for invalid usage of .PATH)
Date: Tue, 9 Apr 2019 10:45:07 -0700

 Yup, that should be great! Thanks!
 
 christos
 
 > On Apr 9, 2019, at 10:44 AM, Simon J. Gerraty <sjg%juniper.net@localhost> wrote:
 >=20
 > Christos Zoulas <christos%zoulas.com@localhost> wrote:
 >=20
 >> I'd rather unconditionally free "paths" if it was not NULL rather =
 than add more complexity
 >> to the code. This function needs to be split up; it is too big and =
 complicated.
 >=20
 > That works for me, so diff is then just:
 >=20
 > diff -r 6f103b9234c3 bmake/parse.c
 > --- a/bmake/parse.c	Sun Dec 30 09:28:02 2018 -0800
 > +++ b/bmake/parse.c	Tue Apr 09 10:42:04 2019 -0700
 > @@ -1768,7 +1768,8 @@
 >     }
 >=20
 > out:
 > -    assert(paths =3D=3D NULL);
 > +    if (paths)
 > +	Lst_Destroy(paths, NULL);
 >     if (curTargs)
 > 	    Lst_Destroy(curTargs, NULL);
 > }
 >=20
 >=20
 > --=20
 > This message has been 'sanitized'.  This means that potentially
 > dangerous content has been rewritten or removed.  The following
 > log describes which actions were taken.
 >=20
 > Sanitizer (start=3D"1554831880"):
 >  Split unusually long word(s) in header.
 >  SanitizeFile (filename=3D"unnamed.txt, =
 68181.1554831865.1%kaos.jnpr.net@localhost", mimetype=3D"text/plain"):
 >    Match (names=3D"unnamed.txt", rule=3D"9"):
 >      Enforced policy: accept
 >=20
 >  Total modifications so far: 1
 >=20
 >=20
 > Anomy 0.0.0 : Sanitizer.pm
 > $Id: Sanitizer.pm,v 1.94 2006/01/02 16:43:10 bre Exp $