[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/53674 CVS commit: src/sys/kern
The following reply was made to PR kern/53674; it has been noted by GNATS.
From: "Maxime Villard" <maxv%netbsd.org@localhost>
Subject: PR/53674 CVS commit: src/sys/kern
Date: Thu, 27 Dec 2018 07:56:43 +0000
Module Name: src
Committed By: maxv
Date: Thu Dec 27 07:56:43 UTC 2018
Fix apparent race.
We're doing a LIST_FOREACH, but unlock filelist_lock in the middle of the
loop and drop the reference to fp. We then read fp->...le_next, but it
may have been freed by another thread.
This is difficult to trigger and observe, probably only KASAN can see
problems of this kind.
Switch to LIST_FOREACH_SAFE, and re-fetch np after re-locking.
May fix PR/53674.
To generate a diff of this commit:
cvs rdiff -u -r1.105 -r1.106 src/sys/kern/uipc_domain.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Main Index |
Thread Index |