Re: kern/53546: ifconfig tapXXXXX problem (wrong unit name or panic)

[christos%zoulas.com@localhost (Christos Zoulas)]

On Aug 24,  9:05am, mlelstv%serpens.de@localhost (Michael van Elst) wrote:
-- Subject: Re: kern/53546: ifconfig tapXXXXX problem (wrong unit name or pan

| The following reply was made to PR kern/53546; it has been noted by GNATS.
| 
| From: mlelstv%serpens.de@localhost (Michael van Elst)
| To: gnats-bugs%netbsd.org@localhost
| Cc: 
| Subject: Re: kern/53546: ifconfig tapXXXXX problem (wrong unit name or panic)
| Date: Fri, 24 Aug 2018 09:00:29 -0000 (UTC)
| 
|  msaitoh%execsw.org@localhost writes:
|  
|  >	ifconfig tap65537 create
|  >	[ 1491.1341302] tap1: Ethernet address f2:0b:a4:1c:e7:17
|  >	(not 65537 but 1)
|  
|  tap is not only an interface but also a character device and both share the
|  same unit number. Device unit numbers are of type 'short'.
|  
|  >	ifconfig tap99999 create
|  
|  that translates to a negative device unit number that isn't validated.
|  
|  Checking the unit number for positive short values in tap_clone_creator()
|  should fix both problems.

Why don't we make cf_unit and dv_unit unsigned int?

christos