PR/48875 CVS commit: src/bin/sh

["Robert Elz" <kre%netbsd.org@localhost>]

The following reply was made to PR bin/48875; it has been noted by GNATS.

From: "Robert Elz" <kre%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/48875 CVS commit: src/bin/sh
Date: Sun, 19 Aug 2018 11:16:13 +0000

 Module Name:	src
 Committed By:	kre
 Date:		Sun Aug 19 11:16:13 UTC 2018
 
 Modified Files:
 	src/bin/sh: eval.c eval.h main.c
 
 Log Message:
 PR bin/48875
 
 Revert the changes that were made 19 May 2016 (principally eval.c 1.125)
 and the bug fixes in subsequent days (eval.c 1.126 and 1.127) and also
 update some newer code that was added more recently which acted in
 accordance with those changes (make that code be as it would have been
 if the changes now being reverted had never been made).
 
 While the changes made did solve the problem, in a sense, they were
 never correct (see the PR for some discussion) and it had always been
 intended that they be reverted.   However, in practical sh code, no
 issues were reported - until just recently - so nothing was done,
 until now...
 
 After this commit, the validate_fn_redirects test case of the sh ATF
 test t_redir will fail.   In particular, the subtest of that test
 case which is described in the source (of the test) as:
 	This one is the real test for PR bin/48875
 will fail.
 
 Alternative changes, not to "fix" the problem in the PR, but to
 often avoid it will be coming very soon - after which that ATF
 test will succeed again.
 
 XXX pullup-8
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.157 -r1.158 src/bin/sh/eval.c
 cvs rdiff -u -r1.20 -r1.21 src/bin/sh/eval.h
 cvs rdiff -u -r1.73 -r1.74 src/bin/sh/main.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.