Re: kern/53447: usb lock problem, mutex_enter

[Phil Nelson <phil%NetBSD.org@localhost>]

The following reply was made to PR kern/53447; it has been noted by GNATS.

From: Phil Nelson <phil%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: kern-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/53447: usb lock problem, mutex_enter
Date: Thu, 12 Jul 2018 17:28:05 -0700

 On Thursday 12 July 2018 14:55:01 Christos Zoulas wrote:
 > =A0Try this:
 > =A0
 > =A0Index: xhci.c
 > =A0=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > =A0RCS file: /cvsroot/src/sys/dev/usb/xhci.c,v
 > =A0retrieving revision 1.93
 > =A0diff -u -u -r1.93 xhci.c
 > =A0--- xhci.c=A0=A0=A0=A0=A029 Jun 2018 17:48:24 -0000=A0=A0=A0=A0=A0=A01=
 =2E93
 > =A0+++ xhci.c=A0=A0=A0=A0=A012 Jul 2018 21:50:51 -0000
 > =A0@@ -1206,7 +1206,7 @@
 >=20
 
 Didn't have the intended effect.  No locking problem because there was
 no console keyboard.  Rebooted several times.
 
 With the patch:
 
 [    1.022047] usb0 at xhci0: USB revision 3.0
 [    1.022047] usb1 at xhci0: USB revision 2.0
 [    1.022047] usb2 at ehci0: USB revision 2.0
 [    1.022047] usb3 at ehci1: USB revision 2.0
 [    1.590069] uhub0: 2 ports with 2 removable, self powered
 [    1.590069] uhub1 at usb1: NetBSD (0000) xHCI root hub (0000), class 9/0=
 , rev 2.00/1.00, addr 0
 [    1.590069] uhub1: 10 ports with 10 removable, self powered
 [    1.596463] IPsec: Initialized Security Association Processing.
 [    1.606468] uhub2 at usb3: NetBSD (0000) EHCI root hub (0000), class 9/0=
 , rev 2.00/1.00, addr 1
 [    1.606468] uhub2: 2 ports with 2 removable, self powered
 [    1.606468] uhub3 at usb2: NetBSD (0000) EHCI root hub (0000), class 9/0=
 , rev 2.00/1.00, addr 1
 [    1.606468] uhub3: 2 ports with 2 removable, self powered
 
 [    3.847410] uhub4 at uhub3 port 1: Intel (0x8087) product 8008 (0x8008),=
  class 9/0, rev 2.00/0.04, addr 2
 [    3.847410] uhub4: single transaction translator
 [    3.847410] uhub4: 4 ports with 4 removable, self powered
 [    3.857415] uhub5 at uhub2 port 1: Intel (0x8087) product 8000 (0x8000),=
  class 9/0, rev 2.00/0.04, addr 2
 [    3.857415] uhub5: single transaction translator
 [    3.857415] uhub5: 6 ports with 6 removable, self powered
 [    8.199238] uhub1: autoconfiguration error: device problem, disabling po=
 rt 1
 [    8.339294] WARNING: 20 errors while detecting hardware; check system lo=
 g.
 
 
 Before the patch:
 
 [    1.022992] usb0 at xhci0: USB revision 3.0
 [    1.022992] usb1 at xhci0: USB revision 2.0
 [    1.022992] usb2 at ehci0: USB revision 2.0
 [    1.022992] usb3 at ehci1: USB revision 2.0
 
 [    1.596862] uhub0 at usb0: NetBSD (0000) xHCI root hub (0000), class 9/0=
 , rev 3.00/
 1.00, addr 0
 [    1.596862] uhub0: 2 ports with 2 removable, self powered
 [    1.596862] uhub1 at usb1: NetBSD (0000) xHCI root hub (0000), class 9/0=
 , rev 2.00/
 1.00, addr 0
 [    1.596862] uhub1: 10 ports with 10 removable, self powered
 [    1.613272] uhub2 at usb2: NetBSD (0000) EHCI root hub (0000), class 9/0=
 , rev 2.00/
 1.00, addr 1
 [    1.613272] uhub2: 2 ports with 2 removable, self powered
 [    1.613272] uhub3 at usb3: NetBSD (0000) EHCI root hub (0000), class 9/0=
 , rev 2.00/
 1.00, addr 1
 [    1.613272] uhub3: 2 ports with 2 removable, self powered
 
 [    3.223894] uhub4 at uhub1 port 1: Terminus Technology (0x1a40) USB 2.0 =
 Hub (0x101)
 , class 9/0, rev 2.00/1.11, addr 1
 [    3.223894] uhub4: single transaction translator
 [    3.223894] uhub4: 4 ports with 4 removable, self powered
 
 [    3.864142] uhub5 at uhub2 port 1: Intel (0x8087) product 8008 (0x8008),=
  class 9/0, rev 2.00/0.04, addr 2
 [    3.864142] uhub5: single transaction translator
 [    3.864142] uhub6 at uhub3 port 1: Intel (0x8087) product 8000 (0x8000),=
  class 9/0, rev 2.00/0.04, addr 2
 [    3.864142] uhub6: single transaction translator
 [    3.864142] uhub5: 4 ports with 4 removable, self powered
 [    3.864142] uhub6: 6 ports with 6 removable, self powered
 [    4.214277] uhidev0 at uhub4 port 2 configuration 1 interface 0
 [    4.214277] uhidev0: Logitech (0x46d) USB Receiver (0xc52f), rev 2.00/22=
 =2E01, addr 2, iclass 3/1
 [    4.214277] ums0 at uhidev0: 16 buttons, W and Z dirs
 [    4.214277] wsmouse0 at ums0 mux 0
 [    4.214277] uhidev1 at uhub4 port 2 configuration 1 interface 1
 [    4.214277] uhidev1: Logitech (0x46d) USB Receiver (0xc52f), rev 2.00/22=
 =2E01, addr 2, iclass 3/0
 [    4.214277] uhidev1: 17 report ids
 [    4.214277] uhid0 at uhidev1 reportid 3: input=3D4, output=3D0, feature=
 =3D0
 [    4.214277] uhid1 at uhidev1 reportid 16: input=3D6, output=3D6, feature=
 =3D0
 [    4.224279] uhid2 at uhidev1 reportid 17: input=3D19, output=3D19, featu=
 re=3D0
 [    4.884534] uhidev2 at uhub4 port 3 configuration 1 interface 0
 [    4.884534] uhidev2: SONiX (0xc45) USB Keyboard (0x133), rev 1.10/2.00, =
 addr 3, iclass 3/1
 [    4.884534] ukbd0 at uhidev2: 8 Variable keys, 6 Array codes
 [    5.294695] wskbd0 at ukbd0: console keyboard, using wsdisplay0
 [    5.294695] uhidev3 at uhub4 port 3 configuration 1 interface 1
 [    5.294695] uhidev3: SONiX (0xc45) USB Keyboard (0x133), rev 1.10/2.00, =
 addr 3, iclass 3/1
 [    5.294695] uhidev3: 2 report ids
 [    5.294695] uhid3 at uhidev3 reportid 1: input=3D1, output=3D0, feature=
 =3D0
 [    5.294695] uhid4 at uhidev3 reportid 2: input=3D1, output=3D0, feature=
 =3D0
 [    5.434750] WARNING: 19 errors while detecting hardware; check system lo=
 g.
 
 =2D-Phil