Re: kern/52781: audioctl can't set output gain

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR kern/52781; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: Nathanial Sloss <nat%netbsd.org@localhost>, matthew green <mrg%eterna.com.au@localhost>
Cc: gnats-bugs%netbsd.org@localhost, kern-bug-people%netbsd.org@localhost, 
	gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, bouyer%antioche.eu.org@localhost
Subject: Re: kern/52781: audioctl can't set output gain
Date: Sun, 20 May 2018 09:08:39 -0400

 On May 20,  6:59pm, nat%netbsd.org@localhost (Nathanial Sloss) wrote:
 -- Subject: Re: kern/52781: audioctl can't set output gain
 
 | 
 | How about the attached patch it will set the hw gain also if their is only one 
 | channel open (recording or playback).  If this is good I'll document this 
 | behaviour and update the spec.
 | 
 | Best regards,
 | 
 | Nat
 
 I would write this:
 
 | +		if (sc->sc_opens == 1 || !sc->sc_usemixer ||
 | +						 vc == &sc->sc_mixring) {
 
 as a macro or inline function because we keep repeating it.
 
 christos